can't update Rowan about rowan

[ericwinger]

Here's an annoying long partial stack which might help.

Reading /foos2/users/ewinger/GsDevKit_home/shared/repos/Rowan/src/tonel/Rowan-Services/RowanClassService.class.st
Notice: a CypressAddition(add: a CypressMethodDefinition(RowanClassService>>packageName:)) failed because a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
Notice: a CypressAddition(add: a CypressMethodDefinition(RowanClassService>>createSampleClass)) failed because a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
Notice: a CypressAddition(add: a CypressMethodDefinition(RowanMethodService>>classService)) failed because a CompileError occurred (error 1001), undefined symbol  RowanClassDefinitionService
Notice: a CypressAddition(add: a CypressMethodDefinition(RowanMethodService>>createSampleMethod)) failed because a CompileError occurred (error 1001), undefined symbol  RowanClassDefinitionService
Notice: a CypressAddition(add: a CypressMethodDefinition(RowanPackageService>>createSamplePackage)) failed because a CompileError occurred (error 1001), undefined symbol  RowanProjectDefinitionService
Notice: a CypressAddition(add: a CypressMethodDefinition(RowanPackageService>>createPackage)) failed because a CompileError occurred (error 1001), undefined symbol  RowanProjectDefinitionService
Notice: a CypressAddition(add: a CypressMethodDefinition(RowanPackageService>>createPackageNamed:inProject:)) failed because a CompileError occurred (error 1001), undefined symbol  RowanProjectDefinitionService
ERROR 2710 , a CypressAddition(add: a CypressMethodDefinition(RowanClassService>>packageName:)) failed because a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService (CypressLoaderError)
topaz > exec iferr 1 : stk 
==> 1 CypressLoaderError (AbstractException) >> _signalWith: @6 line 25
2 CypressLoaderError (AbstractException) >> signal @2 line 47
3 CypressLoader >> handlePatchOperation:failure: @3 line 8
4 [] in CypressLoader >> loadMethodDefinition:  @19 line 8
5 CompileError (AbstractException) >> _executeOuterHandler: @4 line 7
6 CompileError (AbstractException) >> _pass:with: @5 line 13
7 CompileError (AbstractException) >> pass      @2 line 14
8 CypressLoader >> handleCompileError:from:     @10 line 9
9 [] in CypressLoader >> loadMethodDefinition:  @15 line 6
10 CompileError (AbstractException) >> _executeHandler: @8 line 11
11 CompileError (AbstractException) >> _signalWith: @1 line 1
12 CompileError (AbstractException) >> signal    @2 line 47
13 RowanClassService class (Behavior) >> _checkCompileResult:source:suppressCompileWarning: @12 line 21
14 GsPackagePolicy >> extractSelectorFor:source:dictionaries:category: @15 line 16
15 GsPackagePolicy >> methodAndCategoryDictionaryFor:source:dictionaries:category: @5 line 9
16 RowanClassService class (Behavior) >> compileMethod:dictionaries:category:environmentId: @14 line 39
17 CypressMethodDefinition >> loadMethodDefinition @7 line 4
18 CypressAddition >> loadMethodDefinition       @3 line 2
19 [] in CypressLoader >> loadMethodDefinition:  @11 line 4
20 ExecBlock0 (ExecBlock) >> on:do:              @3 line 44
21 [] in CypressLoader >> loadMethodDefinition:  @7 line 5
22 ExecBlock0 (ExecBlock) >> on:do:              @3 line 44
23 CypressLoader >> loadMethodDefinition:        @3 line 7
24 [] in CypressLoader >> loadAdditions:         @12 line 6
25 OrderedCollection (Collection) >> do:         @6 line 10
26 CypressLoader >> loadAdditions:               @4 line 6
27 CypressLoader >> retryFailedLoads             @9 line 12
28 CypressLoader >> load                         @5 line 7
29 CypressPackageManager3 >> loadResolvedReferences @9 line 12
30 Executed Code                                 @10 line 13
31 GsNMethod class >> _gsReturnToC               @1 line 1
topaz > exec iferr 2 : stack 
==> 1 CypressLoaderError (AbstractException) >> _signalWith: @6 line 25
    receiver a CypressAddition(add: a CypressMethodDefinition(RowanClassService>>packageName:)) failed because a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    inCextensionArg nil
    res nil
(skipped 1 evaluationTemps)
2 CypressLoaderError (AbstractException) >> signal @2 line 47
    receiver a CypressAddition(add: a CypressMethodDefinition(RowanClassService>>packageName:)) failed because a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
(skipped 2 evaluationTemps)
3 CypressLoader >> handlePatchOperation:failure: @3 line 8
    receiver aCypressLoader
    aPatchOperation aCypressAddition
    anException a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
(skipped 1 evaluationTemps)
4 [] in CypressLoader >> loadMethodDefinition:  @19 line 8
    self aCypressLoader
    receiver anExecBlock1
    ex a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    aPatchOperation aCypressAddition
    self aCypressLoader
(skipped 4 evaluationTemps)
5 CompileError (AbstractException) >> _executeOuterHandler: @4 line 7
    receiver a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    aBlock anExecBlock1
(skipped 4 evaluationTemps)
6 CompileError (AbstractException) >> _pass:with: @5 line 13
    receiver a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    aHandler anExecBlock1
    isNonStaticAnsi true
(skipped 3 evaluationTemps)
7 CompileError (AbstractException) >> pass      @2 line 14
    receiver a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
(skipped 4 evaluationTemps)
8 CypressLoader >> handleCompileError:from:     @10 line 9
    receiver aCypressLoader
    aCompileError a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    aPatchOperation aCypressAddition
    undefinedSymbolErrors anArray
    otherErrors anArray
(skipped 1 evaluationTemps)
9 [] in CypressLoader >> loadMethodDefinition:  @15 line 6
    self aCypressLoader
    receiver anExecBlock1
    ex a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    aPatchOperation aCypressAddition
    self aCypressLoader
(skipped 4 evaluationTemps)
10 CompileError (AbstractException) >> _executeHandler: @8 line 11
    receiver a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    aBlock anExecBlock1
    res nil
(skipped 2 evaluationTemps)
11 CompileError (AbstractException) >> _signalWith: @1 line 1
    receiver a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
    inCextensionArg nil
12 CompileError (AbstractException) >> signal    @2 line 47
    receiver a CompileError occurred (error 1001), undefined symbol  RowanPackageDefinitionService
(skipped 2 evaluationTemps)
13 RowanClassService class (Behavior) >> _checkCompileResult:source:suppressCompileWarning: @12 line 21
    receiver RowanClassService
    result anArray
    sourceString packageName: packageName\n	\n	packageService ifNil:[packageService := RowanPackageDefinitionService new packageName: packageName].\n	^packageService packageName\n
    suppressCompileWarning true
    meth nil
    warnStr nil
    errorArray anArray
(skipped 2 evaluationTemps)
14 GsPackagePolicy >> extractSelectorFor:source:dictionaries:category: @15 line 16
    receiver aGsPackagePolicy
    aBehavior RowanClassService
    sourceString packageName: packageName\n	\n	packageService ifNil:[packageService := RowanPackageDefinitionService new packageName: packageName].\n	^packageService packageName\n
    aSymbolList aSymbolList
    categorySymbol examples
    mDict aGsMethodDictionary
    cDict aGsMethodDictionary
    meth nil
    symList aSymbolList
    sel nil
(skipped 4 evaluationTemps)
15 GsPackagePolicy >> methodAndCategoryDictionaryFor:source:dictionaries:category: @5 line 9
    receiver aGsPackagePolicy
    aBehavior RowanClassService
    sourceString packageName: packageName\n	\n	packageService ifNil:[packageService := RowanPackageDefinitionService new packageName: packageName].\n	^packageService packageName\n
    aSymbolList aSymbolList
    categorySymbol examples
    selector nil
(skipped 5 evaluationTemps)
16 RowanClassService class (Behavior) >> compileMethod:dictionaries:category:environmentId: @14 line 39
    receiver RowanClassService
    sourceString packageName: packageName\n	\n	packageService ifNil:[packageService := RowanPackageDefinitionService new packageName: packageName].\n	^packageService packageName\n
    aSymbolList aSymbolList
    aCategoryString examples
    anEnvironmentId 0
    symList aSymbolList
    categ examples
    mDict nil
    cDict nil
    pArray nil
    dictsArray nil
    meth nil
(skipped 5 evaluationTemps)
17 CypressMethodDefinition >> loadMethodDefinition @7 line 4
    receiver aCypressMethodDefinition
(skipped 5 evaluationTemps)
18 CypressAddition >> loadMethodDefinition       @3 line 2
    receiver aCypressAddition
(skipped 1 evaluationTemps)
19 [] in CypressLoader >> loadMethodDefinition:  @11 line 4
    self aCypressLoader
    receiver anExecBlock0
    aPatchOperation aCypressAddition
(skipped 2 evaluationTemps)
20 ExecBlock0 (ExecBlock) >> on:do:              @3 line 44
    self aCypressLoader
    receiver anExecBlock0
    exceptionSelector CompileError
    handlerBlock anExecBlock1
    fastPath true
(skipped 1 evaluationTemps)
21 [] in CypressLoader >> loadMethodDefinition:  @7 line 5
    self aCypressLoader
    receiver anExecBlock0
(skipped 4 evaluationTemps)
22 ExecBlock0 (ExecBlock) >> on:do:              @3 line 44
    self aCypressLoader
    receiver anExecBlock0
    exceptionSelector Error
    handlerBlock anExecBlock1
    fastPath true
(skipped 1 evaluationTemps)
23 CypressLoader >> loadMethodDefinition:        @3 line 7
    receiver aCypressLoader
    aPatchOperation aCypressAddition
(skipped 4 evaluationTemps)
24 [] in CypressLoader >> loadAdditions:         @12 line 6
    self aCypressLoader
    receiver anExecBlock1
    each aCypressAddition
    self aCypressLoader
(skipped 3 evaluationTemps)
25 OrderedCollection (Collection) >> do:         @6 line 10
    receiver anOrderedCollection
    aBlock anExecBlock1
    i 1
(skipped 4 evaluationTemps)
26 CypressLoader >> loadAdditions:               @4 line 6
    receiver aCypressLoader
    somePatchOperations anOrderedCollection
(skipped 4 evaluationTemps)
27 CypressLoader >> retryFailedLoads             @9 line 12
    receiver aCypressLoader
    failed anOrderedCollection
(skipped 3 evaluationTemps)
28 CypressLoader >> load                         @5 line 7
    receiver aCypressLoader
(skipped 2 evaluationTemps)
29 CypressPackageManager3 >> loadResolvedReferences @9 line 12
    receiver aCypressPackageManager3
    cypressLoader aCypressLoader
(skipped 2 evaluationTemps)
30 Executed Code                                 @10 line 13
    receiver nil
    packageManager aCypressPackageManager3
    repo aCypressTonelRepository
(skipped 2 evaluationTemps)
31 GsNMethod class >> _gsReturnToC               @1 line 1
    receiver GsNMethod
topaz > exec iferr 3 : exit 1 
Logging out session 1.
--- 04/05/2018 15:30:50.508 PDT Logging out
Error on or near line 64 :: startTopaz test_rowan_340 -l :: startTopaz test_rowan_340 -l
~/Scripts
ewinger@foos:~/Scripts$ 

[ericwinger]

I think I've broken it. 🥇

Working on fixing my services code.

[dalehenrich]

Looks like you might stil have some references to the old class names in some of your methods:

packageName: packageName
	packageService ifNil:[packageService := RowanPackageDefinitionService new packageName: packageName].
^packageService packageName

don't know why source show with \n instead of an actual CR, but it's probably a Windows/Dolphin thing?

Anyway, RowanPackageDefinitionService references were left in methods after you renamed the class to RowanPackageService ... When tODE does a rename of a class, a window is brought showing the methods that referenced the class before the rename ... I don't know what Jade does in this case ... also tODE/GLASS does allow a method to be recompiled with references to undefined Globals ... I don't know how GBS handles things in this case ...

For Rowan/Jadeite, we need to make sure that we don't let something like this fall between the cracks --- if indeed things are as I surmise they are...

[ericwinger]

Yes, that is correct. I found it last night but forgot to update the issue. (apologies for wasting your time).

When I bungled this, I didn't have any Jadeite tools available as I was trying to fix a prior problem which broke my browser. So I was recovering using hand-edited fileouts from a backup.

When you're in, let's walk through backing out my last check-in which will be a good learning opportunity for me.

[dalehenrich]

walked through and updated