Add Proxy-Connection: Keepalive Header for HTTP/1.0 requests about px

[genotrance]

I can add this behavior fairly easily but I'm wondering if this is how cNTLM or NTLMaps work on behalf of HTTP/1.0 clients. I guess considering that Px is having the conversation with the NTLM server, it would have to keep the connection alive for the conversation to happen.

Also, curious if the client is expected to do anything special to close the connection and if Px needs to do that as well on behalf of the client.

[holgerreif]

px itself closes the connection after it receives the response from real proxy. So it does not keep the connection open on behalf of the client.

Actually the sequence looks as follows:

#  proxy          px          client
1                     request
                      <------
2   request & keep-alive & Proxy-Authenticate
        <------
3   407 & keep-alive & Proxy-Authenticate
        ------>
4   request & keep-alive & Proxy-Authenticate
        <------
5                     response
                      ------->
6  [ closing connection ]

I actually checked what cntlm does. If I do the failing case (curl --proxy 127.0.0.1:3128 --proxy-header Proxy-Connection: -v -0 http://some.server.de) and sniff the connection between cntlm and the proxy I can see the Proxy-Connection: keep-alive header in both step 2 and 4.

[genotrance]

So just to confirm, the code change required is as follows:-

if connection == "HTTP/1.0" and keepAliveHeader == False:
   Send keep-alive on behalf of client

By the way, which HTTP client are you using that's using 1.0 without the header?

[genotrance]

I've checked in a fix for this issue - can you please verify that it works as expected for you? I couldn't reproduce the failure with my NTLM proxy which didn't care that keep-alive was missing for an HTTP/1.0 client.

[genotrance]

Just posted v0.3.0 so marking this as closed.