GithubHelp home page GithubHelp logo

検討事項 about api-connectors HOT 7 OPEN

gentarok avatar gentarok commented on June 29, 2024
検討事項

from api-connectors.

Comments (7)

gentarok avatar gentarok commented on June 29, 2024
  • Newtonsoft.Json から System.Text.Json に変更したい

from api-connectors.

gentarok avatar gentarok commented on June 29, 2024
  • Model に定義されている型は record にしても良い気がする

from api-connectors.

gentarok avatar gentarok commented on June 29, 2024
  • Null許容参照型を有効にしたい。

from api-connectors.

gentarok avatar gentarok commented on June 29, 2024
  • xxApiクラスの分類が謎なんでAPI KEYの有無かInverse Perpetual/USDT Perpetualで分類し直したい。

from api-connectors.

gentarok avatar gentarok commented on June 29, 2024
  • Records.cs がデケェので分割したいけど、APIを分割するならその粒度に合わせてやりたい。
  • Inverse PerpetualとUSDT Perpetualで同じ列挙名でも中身の異なるものがあったりするので、その辺考えてから。

from api-connectors.

gentarok avatar gentarok commented on June 29, 2024
  • 全体的に見直したいモノ
    • パラメータチェックの方法
    • レスポンス用の型メンバのNullable
    • 構造的な重複をもうちょっと減らせないか

from api-connectors.

gentarok avatar gentarok commented on June 29, 2024

メモ
record typeの定義の重複を排除しようとするとジェネリックスを使うしか無い(継承ではプライマリコンストラクタの引数を減らせない)が、ジェネリックスにするとそれはそれで入れ子のジェネリックスになって見通しが悪くなる…。

public record Response<T>(int RetCode, string RetMsg, string ExtCode, string? ExtInfo, T? Result, string TimeNow,
        int RateLimitStatus, long RateLimitResetMs, int RateLimit);

public record XXXRes(int MemberA, string MemberB);

//こういうのすげぇ読みづらい…
Task<ApiResponse<Reponse<IReadOnlyList<XXXRes>>>>> GetXXX();

from api-connectors.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.