When uploading a CSV file with a unique value in the column

Nice find, <a class="user-mention notranslate" data-hovercard-type="user" data-hoverca

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

<a target="_blank" rel="noopener noreferrer nofollow" href="https://user-images.github

Label selector does not show up when uploading a unique series. about trainset HOT 5 CLOSED

levaphenyl commented on June 25, 2024

Label selector does not show up when uploading a unique series.

from trainset.

daterdots commented on June 25, 2024 1

Nice find, @levaphenyl. @rushk014 would you be able to fix this? When using the attached CSV, the label selector tool fails to load.
testset.csv

from trainset.

abroekhof commented on June 25, 2024 1

I've created a PR to fix this, see above

from trainset.

daterdots commented on June 25, 2024 1

@abroekhof - we have penciled in a day this week to close out a lot of these PRs. Hopefully it's integrated and deployed by the end of the week.

from trainset.

daterdots commented on June 25, 2024

from trainset.

levaphenyl commented on June 25, 2024

The problem is located in Labeler.vue. When there is only one series, the seriesSelector element is hidden: https://github.com/Geocene/trainset/blob/master/src/views/Labeler.vue#L404

This is fully correct. However, the problem is that the labelSelector is nested inside the seriesSelector here: https://github.com/Geocene/trainset/blob/master/src/views/Labeler.vue#L57

Consequently, when hiding the series selector, the labels selectors also gets hidden. Hence the bug!

I tried to fix this locally with the intent of opening a PR but un-nesting labelSelector messes up the CSS layout. I am not competent here 😅.

from trainset.

Recommend Projects