GithubHelp home page GithubHelp logo

Comments (5)

jorisvandenbossche avatar jorisvandenbossche commented on May 22, 2024

I think this is related to https://github.com/darribas/contextily/issues/10. We want to have more complete list of providers, but also objects that contain more information than only the url (so eg also the attribution, max zoom level etc). Once we have that, we should indeed use that here to prevent this from happening.

See also https://github.com/darribas/contextily/pull/66 for an initial to start to get this information from leaflet-providers.js.

from contextily.

jorisvandenbossche avatar jorisvandenbossche commented on May 22, 2024

With #66 in, this should now be an straightforward enhancement, as the provider dicts have an optional min_zoom and max_zoom keys which can be checked.

from contextily.

FelipeSBarros avatar FelipeSBarros commented on May 22, 2024

Hey there, I was taking a look in the issues to see if there is something I could help with.

I forked this repo and clone to my machine.
I realized that you are not using python poetry to manage the package (Is that right?).
So I installed all dependencies in requirements.txt.
Now I am wondering how can I run the test to confirm I have all set to start contributing (It doesn't means I will work in this issue.... I see it is already done, right?).
Thanks in advance

from contextily.

FelipeSBarros avatar FelipeSBarros commented on May 22, 2024

Just to mention that I could run the tests with pytest.
I will look around the issues to see where I could help.
best

from contextily.

darribas avatar darribas commented on May 22, 2024

Hello @FelipeSBarros, thanks very much for the interest and work!

You're right, we don't use poetry. If you want to run the tests locally, the command we use on CI is:

run: pytest -v . --cov=contextily --cov-append --cov-report term-missing --cov-report xml

Note you'll need the dev requirements (Python 3.7, and Python 3.8 and beyond).

from contextily.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.