geos-esm / carma

CARMA

carma's Issues

Radiation looking for "run_aerosol_optics" as opposed to "aerosol_optics"

I've recently come across the issue that in more recent versions of the radiation code, the hook for running the aerosol optics function looks for the function "run_aerosol_optics" as opposed to "aerosol_optics". This change is not yet reflected in CARMA.

I fixed this in my local sandbox by changing this line:

CARMA/CARMAchem_GridCompMod.F90

Line 751 in 6e64d6e

call ESMF_MethodAdd(aero, label='aerosol_optics', userRoutine=aerosol_optics, __RC__)

to call ESMF_MethodAdd(aero, label='run_aerosol_optics', userRoutine=aerosol_optics, __RC__)

I would be happy to submit a PR with this, just want to make sure that run_aerosol_optics is the convention moving forward before I do.

Manage line length in fortran code

Various files in the CARMA source code have very long lines (>150 characters). Fortran compilers don't like this and it requires extra compiler flags, which is annoying if we want to be able to compile CARMA in different environments.

We should get the line length in the CARMA code down to <80 characters.

Identified problem files:

• carmastate_mod.F90