Comments (3)
Some things I found:
composer-installers
disallows packages of typenpm-asset
. Given that this project is a Drupal module meant for a wide audience, we shouldn't be specifying how thenpm-asset/select2
package is installed. However, that's a conversation out of scope here. I just removedextra.installer-types.npm-asset
.- Moving PHPCS behavior out of CodeClimate and into Github Actions is not hard at all. Clicking 'New Action' gave me a handy template which I modified. The phpcs runner lives in composer.json where it's called by the new Github Action.
- Performing a PHPCS scan of the whole codebase reveals that many files are not up to coding standards. This is an issue because we don't want to change the whole codebase in one go (we could fix many issues with phpcbf). Ideally we'd only scan changed/added files, which remains a little bit of a challenge given resource constraints. We could investigate https://github.com/tj-actions/changed-files and other similar packages which probably exist.
- We want to be able to show code coverage for tests. One solution to this could be to generate an HTML coverage report. The problem is that dktl does the actual test running, and it generates clover reports. This means either changing dktl, or discovering a way to convert clover to HTML, or perhaps finding a github-native way of displaying this information from an artifact.
- composer.json is now configured so that packages will be sorted when you require them. :-)
from dkan.
Thanks on your work on this @paul-m! Let's discuss after standup today.
from dkan.
CodeClimate is working now.
from dkan.
Related Issues (20)
- Migration Issues with DKAN for an already existing Drupal7-DKAN-based Data Platform
- Remove dependencies on contracts, locker and procrastinator libraries
- Remove RootedJsonData and revert to simpler validation HOT 1
- Restrict DB query abstraction to the Datastore module HOT 1
- Many "no data-dictionary found" errors despite dictionary mode being disabled
- Unable to remove a harvest without deleting its datasets HOT 1
- Wrong data set identifier / distributionID listed on website HOT 2
- Data missing when submitting POST query HOT 6
- File upload extension limit HOT 1
- Error While Adding Dataset in DKAN
- Support CSV dialects HOT 3
- PHP 8.1 fails tests because of Guzzle HOT 4
- Docs not working HOT 4
- Cannot create sample-content and there are no related errors in the recent log messages HOT 9
- All /dataset/dataset-uuid 404 page not found HOT 3
- Basic harvest error - one DKAN2 instance harvesting from another HOT 2
- Missing feature of recline.js chart / table / map in DKAN 2.x HOT 1
- Harvest deregister missing message HOT 1
- dkan:harvest:status - Undefined array key HOT 1
- Could not build the front-end. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dkan.