connects to NuCivic/ga_gbpw#156 Is react-dash adding bootstrap? normally we have

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Bootstrap is already available so lets not add it again for dkan dashboards about dkan_dash HOT 5 CLOSED

alexiscott commented on June 17, 2024

Bootstrap is already available so lets not add it again for dkan dashboards

from dkan_dash.

Comments (5)

alexiscott commented on June 17, 2024

Accidentally closed.

from dkan_dash.

alexiscott commented on June 17, 2024

[X] Remove bootstrap from package.json as it was loading automatically on pages without any explicit import.
[X] Have react dash pull from the integration branch tag on NuCivic. Later on to update to master tag.

from dkan_dash.

alexiscott commented on June 17, 2024

QA steps

Confirm that boostrap is not loaded by react-dash in the dashboard.

[ ] It should not have the grey background behind the breadcrumbs.
https://63386161-462c-4bc1-b5a5-51aea47318f6--pr-152.probo.build/dashboard/summary?School%20Name=Atlanta%20Heights%20Charter%20School&School%20Year=2015-16

Release notes

PR on DKAN_DASH with latest files from ga_gbpw merged in.
#19

https://github.com/NuCivic/ga_gbpw/pull/152

Release is currently blocked by this issue:
#20

from dkan_dash.

janette commented on June 17, 2024

@alexiscott this looks good, but seems like the react-dash CHANGELOG.md needs to be updated, when you tagged react-dash did you follow these steps?
NuCivic/react-dash@887c15f#diff-ffbfa59918f1d1346372f60f6969ba2cR19

from dkan_dash.