GithubHelp home page GithubHelp logo

Comments (7)

michalzelechowski-getindata avatar michalzelechowski-getindata commented on September 26, 2024

We have the following options:

  • environment [all]
  • image [compile,upload_pipeline,run_once]
  • output [upload_pipeline,schedule,run_once]
  • cron-expression [schedule]
  • dag_name [run_once]
  • wait_for_completion [run_once]

Environment is a group option so it stays. Image is already in the config. Output seems to be good candidate as it's tied to the environment in the first place. Cron-expression is specific but it seems to be tied to the project. dag_name is by default derived from package_name - what do you think @em-pe ? Also we have experiment_name (that's internal but related to the dag_name) that's derived from package_name - should we put it into config as well? wait_for_completion is a runtime option.

from kedro-airflow-k8s.

em-pe avatar em-pe commented on September 26, 2024

Here are my suggestions:
experiment_name -> put in config, default to package name
image -> put in config, allow override through optional console param
output -> put in config, allow to override through console param
cron expression -> put in config, default to @daily
dag_name -> put in config, default to package name, allow to override through console param
wait for completion -> put in config, allow override through console param

Regarding defaults, have a look at templated config loader - we could add env variable that we populate with package_name, and instead of custom default handling we just initialise project with config file that explicitly configures all the defaults.

experiment_name: {package_name}

from kedro-airflow-k8s.

michalzelechowski-getindata avatar michalzelechowski-getindata commented on September 26, 2024

cron expression -> put in config, default to @daily

@em-pe We should use it only for schedule, or also for upload-pipeline? Assuming run-once should ignore this config parameter.

from kedro-airflow-k8s.

michalzelechowski-getindata avatar michalzelechowski-getindata commented on September 26, 2024

I am a bit reluctant to put wait_for_completion to config, as it would be hard to force case when you don't want plugin to wait (since parameter takes int describing timeout rather than bool flag).

from kedro-airflow-k8s.

em-pe avatar em-pe commented on September 26, 2024

@michalzelechowski-getindata let's use it for both, we may then get rid of the schedule command I believe. Regarding wait for completion, let's leave it as CLI option now. In kedro-kubeflow the behavior is slightly different as there is an option to submit pipeline for execution and be done without waiting for it to complete.

from kedro-airflow-k8s.

michalzelechowski-getindata avatar michalzelechowski-getindata commented on September 26, 2024

@em-pe I think it makes sense for the schedule to allow for override from CLI, in contrary to upload-pipeline so I suggest we keep it separate for better flexibility and alignment with kedro-kubeflow.

from kedro-airflow-k8s.

em-pe avatar em-pe commented on September 26, 2024

@michalzelechowski-getindata sounds good to me

from kedro-airflow-k8s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.