Comments (7)
We have the following options:
- environment [all]
- image [compile,upload_pipeline,run_once]
- output [upload_pipeline,schedule,run_once]
- cron-expression [schedule]
- dag_name [run_once]
- wait_for_completion [run_once]
Environment is a group option so it stays. Image is already in the config. Output seems to be good candidate as it's tied to the environment in the first place. Cron-expression is specific but it seems to be tied to the project. dag_name is by default derived from package_name - what do you think @em-pe ? Also we have experiment_name (that's internal but related to the dag_name) that's derived from package_name - should we put it into config as well? wait_for_completion is a runtime option.
from kedro-airflow-k8s.
Here are my suggestions:
experiment_name -> put in config, default to package name
image -> put in config, allow override through optional console param
output -> put in config, allow to override through console param
cron expression -> put in config, default to @daily
dag_name -> put in config, default to package name, allow to override through console param
wait for completion -> put in config, allow override through console param
Regarding defaults, have a look at templated config loader - we could add env variable that we populate with package_name
, and instead of custom default handling we just initialise project with config file that explicitly configures all the defaults.
experiment_name: {package_name}
from kedro-airflow-k8s.
cron expression -> put in config, default to @daily
@em-pe We should use it only for schedule,
or also for upload-pipeline
? Assuming run-once
should ignore this config parameter.
from kedro-airflow-k8s.
I am a bit reluctant to put wait_for_completion
to config, as it would be hard to force case when you don't want plugin to wait (since parameter takes int describing timeout rather than bool flag).
from kedro-airflow-k8s.
@michalzelechowski-getindata let's use it for both, we may then get rid of the schedule
command I believe. Regarding wait for completion, let's leave it as CLI option now. In kedro-kubeflow the behavior is slightly different as there is an option to submit pipeline for execution and be done without waiting for it to complete.
from kedro-airflow-k8s.
@em-pe I think it makes sense for the schedule
to allow for override from CLI, in contrary to upload-pipeline
so I suggest we keep it separate for better flexibility and alignment with kedro-kubeflow.
from kedro-airflow-k8s.
@michalzelechowski-getindata sounds good to me
from kedro-airflow-k8s.
Related Issues (20)
- Make it possible to override Kedro parameters when triggering run HOT 1
- kedro-airflow-k8s does not support KEDRO_ENV
- Compile step broken with kedro==0.18.0 HOT 3
- Add support for --dag-name flag to schedule step.
- Ensure pipeline works when git not initialized
- Fix typo in docs/03_getting_started/01_quickstart.md HOT 1
- Replace hardcoded '/opt' in project_path in spark job with PROJECT_HOME env HOT 1
- ValueError: Failed to format pattern '${xxx}': no config value found, no default provided HOT 6
- Add custom script injection to airflow_spark_task_template HOT 1
- Invalid status in Mlflow during pipeline execution
- Airflow run dag with config HOT 4
- feature request: Group kedro nodes in same DAG task
- Update kedro dependencies HOT 1
- Add support for python 3.9 and 3.10
- Set up Dependabot and CodeQL
- Update kfp dependencies HOT 1
- Add ability to specify service accounts and imagePullSecrets to run the pipeline with
- Invalid configuration generated by `kedro airflow-k8s init` HOT 3
- kedro-airflow-k8s[gcp] depends on nonexistent library HOT 2
- Authentication to MLFlow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kedro-airflow-k8s.