Comments (3)
Yeah that one has been bothering me for a while, and your solution makes a lot of sense ! All that would be needed is to build that link in the frontend directly, since it's the same domain to accept and create invitations. It would solve the email problem in a quite elegant way, and all you'd have to do is share the invite link with the other user 😄
from meli.
OK. I made those changes at it worked pretty much as planned. I'll try to submit a PR tomorrow for this bit. Any suggestions for what tests you want? All it does is add a URL field the the invite list payload. I can try and dig around and find any tests that might be checking those payload.
The UI is identical except just before the email address of the person I include FontAwesome link icon that is a hyperlink to the invitation. Is that good for you or were you thinking of something else? I could also put the link at the end of the row, but there are already a couple of things going on there including the "delete" x
and I hate to put the link too close to that.
Just let me know.
from meli.
This is awesome! Do you have a screenshot of what you're describing ? Your change seems fine, I'd just suggest copying the invite URL to the clipboard when the user clicks the link icon. We already have a CopyToClipboard component that we use for copying API tokens. I would suggest updating the CopyToClipboard
component to allow changing the initial label so you get set Copy invitation link
instead of the default Copy to clipboard
tooltip. What do you think ?
Regarding tests, if you haven't changed the payload returned by the backend, I'd just leave it as is, otherwise if you feel like adding a jest test for that endpoint, you're welcome to do so, I have no specific guidelines. I know the project lacks testing, that's certain.
from meli.
Related Issues (20)
- Configuration Issues HOT 2
- Gitlab Docs are Wrong HOT 2
- Better diagnostics and/or default for MELI_MAX_ORGS HOT 3
- Protect sites with user authentication HOT 4
- Helm chart? HOT 7
- Handling of MAX_ORGS is not right HOT 3
- Site Domains HOT 5
- Password not working HOT 1
- Add domain redirection
- Is this project dead? HOT 1
- Adding a manually created SSL certificate to Meli
- Project state? HOT 2
- Deploy Remix app with Prisma and Postgres HOT 3
- Is document site down ? HOT 2
- Support rewrites
- Does it support special path reverse proxy?
- Not Support Gitea Actions Request failed with status code 404 HOT 2
- Support for ARM64
- How to deploy apps like NextJS ??
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meli.