GithubHelp home page GithubHelp logo

Comments (2)

danielschemmel avatar danielschemmel commented on May 23, 2024

Considering that I just tackled this problem manually, I would like to offer taking this on.

Currently the directory structure looks like this:

static
├── css
│   ├── fonts
│   │   ├── academicons.eot
│   │   ├── ...
│   │   └── academicons.woff
│   ├── vendor
│   │   └── main.min.css
│   └── webfonts
│       ├── fa-brands-400.eot
│       ├── ...
│       └── fa-solid-900.woff2
└── js
    └── vendor
        └── main.min.js

I would like to propose putting vendor as the root folder, which would enable me to generate the following folder structure without rewriting the fontawesome or academicons css, as well as make for simple cleanup of the downloaded assets:

static
└── vendor
    ├── css
    │   └── main.min.css
    ├── fonts
    │   ├── academicons.eot
    │   ├── ...
    │   └── academicons.woff
    ├── js
    │   └── main.min.js
    └── webfonts
        ├── fa-brands-400.eot
        ├── ...
        └── fa-solid-900.woff2

The only drawback is that this would require changes to the theme.

from academic-file-converter.

gcushen avatar gcushen commented on May 23, 2024

Since this issue was originally opened, Academic has evolved to using the industry standard Node JS approach to downloading offline assets - see comment at HugoBlox/hugo-blox-builder#1554 (comment) .

At the time of writing, Bootstrap and the speaker notes tool are the only built-in offline assets.

Hence, please consider opening a PR on the Academic repo to improve handling of offline assets in https://github.com/gcushen/hugo-academic/blob/master/package.json and https://github.com/gcushen/hugo-academic/blob/master/scripts/update_bootstrap.sh .

Ideally, we would attempt to integrate the Node JS approach to offline files closely with the Academic online CDN approach, whether that be using Academic's existing Assets Library or refactoring Academic to attempt to grab the versioning of CDN assets from the package.json. A potential issue with the latter is that the CDN package naming and version naming/availability can differ to that in the NPM Package Registry.

As a result of the above effort, our early Python-based approach to downloading assets will likely be deprecated once offline support has migrated to the Node JS approach.

from academic-file-converter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.