GithubHelp home page GithubHelp logo

Comments (2)

ibokuri avatar ibokuri commented on June 2, 2024

Okay, this isn't a Getty issue, but a Getty JSON issue.

The pointer tests, which deserialize into the aforementioned types, all pass even though my repro code doesn't because the test deserializer they use implements both deserializeSeq and deserializeString with deserializeAny. That means that deserialization is driven by the deserializer's input data:

  • If a sequence is encountered, visitSeq is called in the pointer visitor.
  • If a string is encountered, visitString is called in the pointer visitor.

As a result, strings can be deserialized from either sequences or strings, which takes care of all string cases.

However, Getty JSON doesn't use deserializeAny for sequences or strings. So, Getty is finding the child DB for the pointer type, seeing that it's an array, and calling deserializeSeq, which in Getty JSON expects a JSON Array in the input, not a JSON String. Easiest fix I think is to just use deserializeAny for strings and sequences in Getty JSON. Or, handle sequence and string tokens in either functions.

from getty.

ibokuri avatar ibokuri commented on June 2, 2024

Hmm, it might be better to check in the pointer DB if the type being deserialized into is a string. If so, then call deserializeString in the visitor as that's probably what the user is expecting. I think that's a more reasonable default to have. It'd make the lives of deserializers easier as well.

from getty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.