GithubHelp home page GithubHelp logo

Comments (6)

Vecvec avatar Vecvec commented on August 21, 2024 1

have you tried

    glfw.window_hint(WindowHint::ClientApi(ClientApiHint::NoApi));

just before creating the windows. This fixed some issues on some platforms.

from wgpu.

Vecvec avatar Vecvec commented on August 21, 2024 1

That's probably todo with

state.window.make_current();

only some calls can be done without an api (typically because the other api can do this). For example:

window.swap_buffers();

does basically the same thing as

surface_texture.present();

though on the internal API (in this case OpenGL).

Also this conversation should probably be moved to glfw-rs as this is mostly a glfw issue.

Questions I have:

  • Why use Surface Target Unsafe? Couldn't you use a Arc<Window> or use the window.render_context() function?
  • Why glfw.set_swap_interval(glfw::SwapInterval::Sync(1));? Wgpu has it's own presentation mode.
  • Why both state.window.swap_buffers(); and drawable.present(); don't these do the same thing?
    Sorry if these seem like a lot of suggestions, I'm just trying to work out the code.

from wgpu.

Vecvec avatar Vecvec commented on August 21, 2024 1

Copying the code onto my machine and making this the run function

        let mut glfw = glfw::init(fail_on_errors!())
            .unwrap();
        glfw.window_hint(WindowHint::ClientApi(ClientApiHint::NoApi));
        let (mut window, events) =
            glfw.create_window(
                800, 600, "It's SNA time.",
                glfw::WindowMode::Windowed).unwrap();

        let mut state = State::new(&mut window).await;
        //state.window.set_all_polling(true);

        //state.window.make_current();

        //glfw.set_swap_interval(glfw::SwapInterval::Sync(1));

        while !state.window.should_close() {
            glfw.poll_events();
            for (_, event) in glfw::flush_messages(&events) {
                match event {
                    glfw::WindowEvent::Key(Key::Escape, _, Action::Press, _) => {
                        state.window.set_should_close(true)
                    }

                    _ => {}
                }
            }

            match state.render() {
                Ok(_) => {},
                Err(e) => eprintln!("{:?}", e),
            }
            //state.window.swap_buffers();
        }

seems to fix the issue (commented out code is both not required and unsupported). This is definitely a GLFW documentation issue. I'm working on a pull request to fix the docs.

from wgpu.

Vecvec avatar Vecvec commented on August 21, 2024 1

Thank you! By the way, there is a safe way of creating a surface:

instance.create_surface(window.render_context()).unwrap();

from wgpu.

StepingForward avatar StepingForward commented on August 21, 2024

I put it right before creating the window, but it returns a new error:

GLFW Error: Cannot make current with a window that has no OpenGL or OpenGL ES context

from wgpu.

StepingForward avatar StepingForward commented on August 21, 2024

OMG, it works now! Thank you so much!!!

from wgpu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.