GithubHelp home page GithubHelp logo

Buffer leaks about wgpu HOT 3 CLOSED

xiaopengli89 avatar xiaopengli89 commented on August 21, 2024
Buffer leaks

from wgpu.

Comments (3)

teoxoy avatar teoxoy commented on August 21, 2024

Are the StagingBuffers not getting destroyed? Or both the Buffers and the StagingBuffers?

from wgpu.

teoxoy avatar teoxoy commented on August 21, 2024

The issue might also be that we don't unmap the staging buffer once we are done with it

if !staging_buffer.is_coherent {
unsafe {
device
.raw()
.flush_mapped_ranges(raw_staging_buffer, iter::once(0..self.size));
}
}

We could call .flush() on it like in all the other places

unsafe fn flush(&self, device: &A::Device) -> Result<(), DeviceError> {
if !self.is_coherent {
unsafe {
device.flush_mapped_ranges(
self.raw.lock().as_ref().unwrap(),
iter::once(0..self.size),
)
};
}
unsafe { device.unmap_buffer(self.raw.lock().as_ref().unwrap())? };
Ok(())
}

from wgpu.

xiaopengli89 avatar xiaopengli89 commented on August 21, 2024

Are the StagingBuffers not getting destroyed? Or both the Buffers and the StagingBuffers?

It all seems to have leaked.

The issue might also be that we don't unmap the staging buffer once we are done with it

If we drop the resource before free suballocation, the leak is gone, which maybe cause by internal mechanism of gpu-allocator.

from wgpu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.