GithubHelp home page GithubHelp logo

Comments (3)

b-r-hamilton avatar b-r-hamilton commented on August 28, 2024

suggested fix - add a conditional that only computes the above line if t-ll <= x.dims[1][1]
I tried this out in a commit that's in the attached branch

from blues.jl.

b-r-hamilton avatar b-r-hamilton commented on August 28, 2024

Okay, new update. The conditional should actually be t - ll >= t1 - 2*unit.(t1). The 2 is because, for our lagged M matrix, at t = 1yr, the values are 0, and we want to actually have values for the first row of our E matrix.

from blues.jl.

b-r-hamilton avatar b-r-hamilton commented on August 28, 2024

Okay, I think this is my final opinion on this. Except I'm now wondering if this is moot because we shouldn't be subsampling M.
But, for what it's worth it, I think the right conditional is

    xtime = x.dims[1]
    return sum([E[At(ll),:] ⋅ x[At(t-ll),:] for (ii,ll) in enumerate(lags) if t-ll in xtime])

from blues.jl.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.