GithubHelp home page GithubHelp logo

Function `fit( )` not used about divand.jl HOT 4 CLOSED

ctroupin avatar ctroupin commented on July 25, 2024
Function `fit( )` not used

from divand.jl.

Comments (4)

Alexander-Barth avatar Alexander-Barth commented on July 25, 2024

Indeed, the function fit is not used because the functions fithorzlen and fitvertlen generally work better. So far, I did not removed this function because it might break other users code and maybe someday a way is found to improve them.

If this function fit cause confusion, maybe we should remove it as mentioned here:
https://gher-uliege.github.io/DIVAnd.jl/latest/#API-changes

from divand.jl.

ctroupin avatar ctroupin commented on July 25, 2024

Thanks Alex,
it probably makes sense to keep it then.
It caused me a bit (not a lot) of confusion while trying to reply to a user email about how the fit was working, but now it's clear!

from divand.jl.

Alexander-Barth avatar Alexander-Barth commented on July 25, 2024

Would it help if we put them in a file called deprecated.jl ? (they would be still available but it would be clearer that they are not used)

from divand.jl.

ctroupin avatar ctroupin commented on July 25, 2024

Sure, that can be a clean way to do it. Or even if we write "deprecated" before the function definition in the source code can help when one has to dig into the code.

from divand.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.