GithubHelp home page GithubHelp logo

Comments (4)

juanabascal avatar juanabascal commented on July 28, 2024

The problem here is that when the set up of the biometric authentication fails (code pointer) the toggle remains checked. When you click the toggle again, it tries to deactivate biometric authentication but it's not found. An unhandled error is raised and you see the toast with the message "Oops! Something went wrong. Please try again later".

The issue goes away after refreshing the page because the set up never reached the db.

I will raise a PR to do two things in case the biometric authentication set up is not completed.

  1. It till set the toggle back to "not checked" status
  2. Show a toast to the user mentioning there was an error

@dtslvr do you see any issue with the approach? How can I set up i18n of the string I need to use?

from ghostfolio.

dtslvr avatar dtslvr commented on July 28, 2024

I will raise a PR to do two things in case the biometric authentication set up is not completed.

That would be great, @juanabascal! Do you have an idea why the registration may fail in the first place?

How can I set up i18n of the string I need to use?

You can set up the snackbar like this: import-activities-dialog.component.ts
The english string is just fine, you don't have to worry about localization.

from ghostfolio.

juanabascal avatar juanabascal commented on July 28, 2024

Do you have an idea why the registration may fail in the first place?

On my laptop (Macbook 2019) I made it fail by cancelling the browser's dialog to set up the biometric authentication.

After taking a second look to the issue description video I noticed that such dialog doesn't even appear on the screen. I'll dig deeper into this.

@dittodhole does you system have any biometric authentication hardware?

from ghostfolio.

juanabascal avatar juanabascal commented on July 28, 2024

@dittodhole my guess is that the browser you are using doesn't support Authn. However, we could have more visibility on the issue if you log the actual error you're getting.

Just change this code with the following. The error message will be printed in the browser's console.

catchError((error: Error) => {
  console.log(error);
  this.update();

  return EMPTY;
})

from ghostfolio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.