GithubHelp home page GithubHelp logo

Comments (3)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 15, 2024
First of all, thank you for taking the time to write about this issue.

I agree that the note doesn't really belong in the Javadoc for the 
`Thumbnailator` class -- considering that the issue with not handing large 
images is a issue that the entire Thumbnailator library faces (Issue 1) it's 
not isolated to the code in the `Thumbnailator` class.

Therefore, I will remove the note about causing `OutOfMemoryError`s from the 
`Thumbnailator` class.

(The use of `Thumbnails.of` from the `Thumbnailator` class methods is an 
implementation detail, so I'll skip adding that to the javadocs.)

Once again, thank you for giving attention to this issue! :)

----

Some insights into how Thumbnailator currently works under the hood:

The `Thumbnails.of` pathway actually uses the 
`Thumbnailator.createThumbnail(ThumbnailTask)` method as the core resizing 
routine, so that note about causing `OutOfMemoryError`s is not technically 
incorrect, but it's not really necessary, as it's a problem with the 
implementation of the current version of Thumbnailator.

Some of the `Thumbnailator` class methods do use the `Thumbnails.of` method to 
create thumbnails, but those were a result of retrofitting the implementation 
to use the `Thumbnails.of` pathway later on, as new features were added to 
`Thumbnails.of` (such as support for Exif rotation, etc.) but were not being 
applied when using the `Thumbnailator` class methods. (Issue 43)

Original comment by [email protected] on 29 Apr 2014 at 7:12

  • Changed title: Javadoc on Thumbnailator class has unclear remark on OutOfMemoryError
  • Changed state: Accepted
  • Added labels: Component-Docs

from thumbnailator.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 15, 2024
This issue will be addressed in Thumbnailator 0.4.8.

Original comment by [email protected] on 26 Oct 2014 at 5:22

  • Changed state: Started
  • Added labels: Milestone-0.4.8

from thumbnailator.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 15, 2024
This issue has been addressed in Thumbnailator 0.4.8.

Original comment by [email protected] on 1 Dec 2014 at 2:59

  • Changed state: Fixed

from thumbnailator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.