Comments (3)
First of all, thank you for taking the time to write about this issue.
I agree that the note doesn't really belong in the Javadoc for the
`Thumbnailator` class -- considering that the issue with not handing large
images is a issue that the entire Thumbnailator library faces (Issue 1) it's
not isolated to the code in the `Thumbnailator` class.
Therefore, I will remove the note about causing `OutOfMemoryError`s from the
`Thumbnailator` class.
(The use of `Thumbnails.of` from the `Thumbnailator` class methods is an
implementation detail, so I'll skip adding that to the javadocs.)
Once again, thank you for giving attention to this issue! :)
----
Some insights into how Thumbnailator currently works under the hood:
The `Thumbnails.of` pathway actually uses the
`Thumbnailator.createThumbnail(ThumbnailTask)` method as the core resizing
routine, so that note about causing `OutOfMemoryError`s is not technically
incorrect, but it's not really necessary, as it's a problem with the
implementation of the current version of Thumbnailator.
Some of the `Thumbnailator` class methods do use the `Thumbnails.of` method to
create thumbnails, but those were a result of retrofitting the implementation
to use the `Thumbnails.of` pathway later on, as new features were added to
`Thumbnails.of` (such as support for Exif rotation, etc.) but were not being
applied when using the `Thumbnailator` class methods. (Issue 43)
Original comment by [email protected]
on 29 Apr 2014 at 7:12
- Changed title: Javadoc on Thumbnailator class has unclear remark on OutOfMemoryError
- Changed state: Accepted
- Added labels: Component-Docs
from thumbnailator.
This issue will be addressed in Thumbnailator 0.4.8.
Original comment by [email protected]
on 26 Oct 2014 at 5:22
- Changed state: Started
- Added labels: Milestone-0.4.8
from thumbnailator.
This issue has been addressed in Thumbnailator 0.4.8.
Original comment by [email protected]
on 1 Dec 2014 at 2:59
- Changed state: Fixed
from thumbnailator.
Related Issues (20)
- Watermark position incorrect for images re-oriented using EXIF metadata HOT 3
- Move to GitHub (and transition to a Git repository) HOT 5
- Change build from Ant to Maven HOT 4
- Google Project Hosting will drop support for Downloads HOT 3
- Using JAI library? HOT 1
- Thumbnailing problem for a specific JPEG image HOT 1
- OutOfMemoryError: Java heap space / Builder.asBufferedImage HOT 3
- Exception on opening nested folder HOT 5
- Recursively process images in nested directories
- Low quality when resizing a GIF image HOT 2
- Unexpected behaviour when using toFile without an extension matching output format HOT 1
- Support animated GIFs HOT 2
- Implement a workaround for common OutOfMemoryError cases HOT 15
- java.lang.OutOfMemoryError: Java heap space after adding thumbnailator-feature-oom-workaround-SNAPSHOT.jar file HOT 6
- Please retain debug information in published JAR HOT 3
- forceSize Not maintaining the Aspect Ratio of thr original image HOT 5
- "Image cannot be null" when using `Thumbnails.of(BufferedImage...)` HOT 2
- Use embedded thumbnail from large JPEG images HOT 1
- SVG not supported
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thumbnailator.