GithubHelp home page GithubHelp logo

Comments (9)

gildas-lormeau avatar gildas-lormeau commented on May 30, 2024 1

Thank you, I was able to reproduce the issue. Unfortunately, it's a bit harder than usual to debug. I suspect this page overrides standard APIs with non-compliant implementations.

Edit: For the record, the error is thrown when SingleFile generates stylesheet contents.

from single-file-cli.

gildas-lormeau avatar gildas-lormeau commented on May 30, 2024 1

@sdht0 I did some investigation on this particular issue and found the problem. It's due to a script on the page which overrides the native method Function#bind with a non-compliant implementation. Hopefully, this is a practice that is considered as bad for at least 10 years. So, this should me more and more rare. Meanwhile, I added an option --browser-freeze-prototypes to freeze the native methods and circumvent this kind of problem.

from single-file-cli.

sdht0 avatar sdht0 commented on May 30, 2024 1

Thanks a lot @gildas-lormeau! Meanwhile I had sidestepped the issue by simply downloading the whole website using wget ;). Their print view is pretty handy (e.g., http://highscalability.com/blog/2023/7/16/lessons-learned-running-presto-at-meta-scale.html?printerFriendly=true).

from single-file-cli.

gildas-lormeau avatar gildas-lormeau commented on May 30, 2024 1

@readstead Thank you for the additional info, I was able to reproduce and fix the issue in the last version I just published.

@sdht0 You did the right thing ;) And it's true that the page intended for printing is perfect!

from single-file-cli.

melyux avatar melyux commented on May 30, 2024

Just got the same issue with many links on the Web Archive:

Evaluation failed: TypeError: Cannot read properties of undefined (reading 'dataset')

from single-file-cli.

gildas-lormeau avatar gildas-lormeau commented on May 30, 2024

@melyux Can you give me an example of link that would allow me to reproduce your issue?

from single-file-cli.

readstead avatar readstead commented on May 30, 2024

@gildas-lormeau I had a similar thing with Web Archive, this is an example of a page where SingleFile CLI threw this error.

from single-file-cli.

melyux avatar melyux commented on May 30, 2024

Just tried and it's working great now. You are the man

from single-file-cli.

gildas-lormeau avatar gildas-lormeau commented on May 30, 2024

@melyux Thank you :)

from single-file-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.