Comments (2)
Did a bit of investigating:
In single-file-cli-api.js
async function capturePage(options) {
try {
let filename;
const pageData = await backend.getPageData(options);
if (options.includeInfobar) {
await includeInfobarScript(pageData);
}
In back-end/pupeteer.js:
exports.getPageData = async (options, page) => {
return await getPageData(context || browser, page, options);
async function getPageData(context, page, options) {
...
return await page.evaluate(async options => {
return await singlefile.getPageData(options);
}, options);
In singlefile.js in single-file-core:
async function getPageData(options = {}, initOptions, doc = globalThis.document, win = globalThis) {
...
const processor = new SingleFile(options);
return await processor.getPageData();
In Processor#getPageData in single-file-core/single-file-core.js:
async getPageData() {
const commentNode = this.doc.createComment("\n " + (this.options.useLegacyCommentHeader ? util.COMMENT_HEADER_LEGACY : util.COMMENT_HEADER) +
" \n url: " + infobarURL +
(this.options.removeSavedDate ? " " : " \n saved date: " + infobarSaveDate) +
(infobarContent ? " \n info: " + infobarContent : "") + "\n");
From a cursory glance, it looks as though we can just add a removeSavedDate
flag in args.js and a default value in const DEFAULT_OPTIONS
without changing any internal logic as we are only passing around this option object?
from single-file-cli.
@gildas-lormeau That seems to work. Adding a removeSavedDate option field in args.js disables the saved date:
portion in the html. Should I make a PR?
from single-file-cli.
Related Issues (20)
- single-file-cli hangs even on `domcontentloaded` HOT 2
- Not a bug/issue, Wonder if we can get some insight/progress when running with a big url file? HOT 1
- Add an option to import settings from browser when using cli HOT 1
- TypeError: window.singlefile is undefined HOT 3
- support for web pages with charset gbk HOT 2
- Output file names when using `--urls-file` HOT 1
- unknown error: no chrome binary at "/usr/bin/chromium-browser" HOT 5
- Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed HOT 1
- Images don't get downloaded using CLI HOT 1
- Output extension should be .zip if `--compress-content --self-extracting-archive false` is used HOT 3
- Fails to run in drive root on Windows
- Can we use sessionData in CLI? HOT 6
- Unable to download alternative sizes of screen within <picture> tag
- Cannot use `--load-deferred-images-max-idle-time` with `--browser-script` option
- Implement native stealth mode HOT 3
- CLI doesn't capture Web Components HOT 7
- Changelog? HOT 1
- Executing the extension from console? HOT 2
- bypass cloudflare browser check
- Uncaught Error Error: ENAMETOOLONG: name too long, open 'xxxx' at (program) (internal/process/promises:246:10) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from single-file-cli.