GithubHelp home page GithubHelp logo

Comments (2)

Yakabuff avatar Yakabuff commented on May 31, 2024

Did a bit of investigating:

In single-file-cli-api.js

async function capturePage(options) {
	try {
		let filename;
		const pageData = await backend.getPageData(options);
		if (options.includeInfobar) {
			await includeInfobarScript(pageData);
		}

In back-end/pupeteer.js:

exports.getPageData = async (options, page) => {
return await getPageData(context || browser, page, options);
async function getPageData(context, page, options) {
...
		return await page.evaluate(async options => {
			return await singlefile.getPageData(options);
		}, options);

In singlefile.js in single-file-core:

async function getPageData(options = {}, initOptions, doc = globalThis.document, win = globalThis) {
...
const processor = new SingleFile(options);
return await processor.getPageData();

In Processor#getPageData in single-file-core/single-file-core.js:

async getPageData() {
			const commentNode = this.doc.createComment("\n " + (this.options.useLegacyCommentHeader ? util.COMMENT_HEADER_LEGACY : util.COMMENT_HEADER) +
				" \n url: " + infobarURL +
				(this.options.removeSavedDate ? " " : " \n saved date: " + infobarSaveDate) +
				(infobarContent ? " \n info: " + infobarContent : "") + "\n");

From a cursory glance, it looks as though we can just add a removeSavedDate flag in args.js and a default value in const DEFAULT_OPTIONS without changing any internal logic as we are only passing around this option object?

from single-file-cli.

Yakabuff avatar Yakabuff commented on May 31, 2024

@gildas-lormeau That seems to work. Adding a removeSavedDate option field in args.js disables the saved date: portion in the html. Should I make a PR?

from single-file-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.