GithubHelp home page GithubHelp logo

Comments (3)

michaelBelsanti avatar michaelBelsanti commented on May 17, 2024 1

Makes sense. I think it would be best to add an or getenv('EDITOR') after checking for tuifi_default_editor. This way, when a new user tries to edit a file it will default to their preferred editor, and if they wish for tuifi to use a seperate editor, they still can by setting tuifi_default_editor.

from tuifimanager.

GiorgosXou avatar GiorgosXou commented on May 17, 2024

Using EDITOR will use the correct editor out of the box for most users

I didn't know this env-variable existed, I might consider adding it to the fallback line of code that I mention bellow.

If you want to offer the ability to use an editor other than what EDITOR is set to, perhaps you could check if tuifi_default_editor is set, and otherwise fallback to EDITOR?

That's what I've thought about tuifi_default_editor too, and if no env-variable exists, it falls-back to one of those:

DEFAULT_EDITOR = which(getenv('tuifi_default_editor', 'nvim')) or which('emacs') or which('vim') or which('micro') or which('nano') or DEFAULT_OPENER

from tuifimanager.

GiorgosXou avatar GiorgosXou commented on May 17, 2024

https://github.com/GiorgosXou/TUIFIManager/blob/master/CHANGELOG.md#v213

from tuifimanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.