Comments (10)
Hmmmmm, we should figure out why
from giraffe.
Hi David, as far as I know I had to target >= 1.6 because FSharp.Core doesn't target anything lower.
from giraffe.
It could be a remainder from the previous Microsoft.FSharp.Core.netcore package which was the FSharp NuGet lib for .NET Core while it was still in development. Perhaps it is as simple as they didn't bother with targeting anything lower than 1.6 whilst in development and now forgot to check if they can actually target a lower version. I will see if I find something otherwise I can open an issue and ask.
from giraffe.
I've just had a go at this on the train. We can use one of the PCL profiles, which line up to 1.0 & 1.1, then ourselves target netstandard 1.3. However I've tried the following and the packages won't restore:
<TargetFramework>netstandard1.3</TargetFramework>
<PackageTargetFallback Condition=" '$(TargetFramework)' == 'netcoreapp1.3' ">$(PackageTargetFallback);portable-net45+win8;</PackageTargetFallback>
@davidfowl is my understanding correct? Any suggestions?
from giraffe.
Also, in the package description for FSharp.Core the bits in the brackets don't appear to be the official TFMs, or am I wrong about that?
from giraffe.
Reopening because #6 has added RazorLight which targets NETStandard 1.6 again. I have opened an issue to lower it at least to NETStandard 1.5.
In the interim I could move the razor handler into a 2nd assembly (e.g. AspNetCore.Lambda.Razor) if you think there's a lot of value to keep the main package targeting 1.3 now @slang25?
from giraffe.
@dustinmoris FSharp.Core
will not be lowered, see dotnet/fsharp#2501
from giraffe.
Well if we can't target a lower netstandard, how about targeting net451 as well like Kestrel?
from giraffe.
Meh, might not be worth it at this point. Kestrel has also changed to target net46
from giraffe.
ok thanks everyone, I will close this issue then.
from giraffe.
Related Issues (20)
- Add output cache for `VaryByValue`
- Migrate to System.Text.Json HOT 1
- Participate on hacktoberfest 2023? HOT 1
- Never decalre reader with `use` on `ctx.Request.Body` HOT 4
- Upgrade to .NET 8 HOT 6
- LinkGenerator doesn't work with routef HOT 1
- Giraffe 6.2 is breaks against Microsoft.IO.RecyclableMemoryStream 3.0.0 HOT 11
- Returning streams, either with WriteStreamAsync or WriteFileStreamAsync or their handler equivalents, is extremely slow HOT 4
- Question: How to approach outside in testing of a micro service? HOT 2
- Guid pattern in endpoint router matches invalid values, throws System.FormatException HOT 6
- Follow-up from "Minor code optimisation #567"
- Update SECURITY.md
- Start using fantomas to validate code submissions with CI HOT 6
- [README] Suggestion for "Getting Started"'s "Doing it manually" HOT 2
- [question] Would it be possible to make `Giraffe.EndpointRouting` case-sensitive? HOT 3
- Remove NuGet API key from the repository HOT 3
- 6.4.0 release references PR for updating to .NET 7 instead of .NET 8 HOT 1
- EndpointRouting - Create endpoint for multiple http verbs
- Request/discussion: WriteStreamAsync buffer size autotuning and/or increase default buffer size HOT 1
- Update `.vscode` debug configuration to point to existent projects
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from giraffe.