GithubHelp home page GithubHelp logo

Comments (10)

davidfowl avatar davidfowl commented on June 25, 2024 1

Hmmmmm, we should figure out why

from giraffe.

dustinmoris avatar dustinmoris commented on June 25, 2024

Hi David, as far as I know I had to target >= 1.6 because FSharp.Core doesn't target anything lower.

from giraffe.

dustinmoris avatar dustinmoris commented on June 25, 2024

It could be a remainder from the previous Microsoft.FSharp.Core.netcore package which was the FSharp NuGet lib for .NET Core while it was still in development. Perhaps it is as simple as they didn't bother with targeting anything lower than 1.6 whilst in development and now forgot to check if they can actually target a lower version. I will see if I find something otherwise I can open an issue and ask.

from giraffe.

slang25 avatar slang25 commented on June 25, 2024

I've just had a go at this on the train. We can use one of the PCL profiles, which line up to 1.0 & 1.1, then ourselves target netstandard 1.3. However I've tried the following and the packages won't restore:

<TargetFramework>netstandard1.3</TargetFramework>
<PackageTargetFallback Condition=" '$(TargetFramework)' == 'netcoreapp1.3' ">$(PackageTargetFallback);portable-net45+win8;</PackageTargetFallback>

@davidfowl is my understanding correct? Any suggestions?

from giraffe.

slang25 avatar slang25 commented on June 25, 2024

Also, in the package description for FSharp.Core the bits in the brackets don't appear to be the official TFMs, or am I wrong about that?

from giraffe.

dustinmoris avatar dustinmoris commented on June 25, 2024

Reopening because #6 has added RazorLight which targets NETStandard 1.6 again. I have opened an issue to lower it at least to NETStandard 1.5.

In the interim I could move the razor handler into a 2nd assembly (e.g. AspNetCore.Lambda.Razor) if you think there's a lot of value to keep the main package targeting 1.3 now @slang25?

from giraffe.

enricosada avatar enricosada commented on June 25, 2024

@dustinmoris FSharp.Core will not be lowered, see dotnet/fsharp#2501

from giraffe.

TheAngryByrd avatar TheAngryByrd commented on June 25, 2024

Well if we can't target a lower netstandard, how about targeting net451 as well like Kestrel?

from giraffe.

davidfowl avatar davidfowl commented on June 25, 2024

Meh, might not be worth it at this point. Kestrel has also changed to target net46

from giraffe.

dustinmoris avatar dustinmoris commented on June 25, 2024

ok thanks everyone, I will close this issue then.

from giraffe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.