Docker-gc removes too many docker images about girder_worker

[danlamanna]

There's a configuration setting that allows you to specify images that should be exempt from garbage collection, would that be a suitable workaround?

Can we do this only with images we pull/create by default? I don't think Girder Worker should be deleting anything it didn't create.

[zachmullen]

There's a configuration setting that allows you to specify images that should be exempt from garbage collection, would that be a suitable workaround?

[manthey]

Not really, unless the slicer_cli_web plugin can modify this configuration setting. The problem is that I keep having to pull images with slicer_cli_web since they keep getting deleted. Worse is that some are built locally and take a long time to build.

[zachmullen]

We need a virtualenv for docker... does something like that exist?

[danlamanna]

There are labels, i.e. docker run|build --label created-by-girder-worker ....

[manthey]

I'm not sure how we'd use that with images we pull via girder worker.

For containers, perhaps we should be running them with the --rm flag.

[manthey]

Fixed via PR #107.