Comments (9)
It would be helpful to print the source and target types when that exception is raised for easy debugging
from girder_worker.
Indeed. There is also an actual bug here that we should fix, which is that the exception that we propagate in this case is pretty unhelpful. We should catch it and raise one of our own that contains information about the spec that caused the breakage, most importantly the source and dest types and formats, and the id of the input or output.
from girder_worker.
It looks like there exists a type/format combination in your spec that isn't registered in the worker.
Looking at your type/formats I would guess it's because string/string
should be string/text
. Let me know if that doesn't fix it for you.
from girder_worker.
The functions that determine how to go from one format to another have no idea what piece of data they're dealing with, and I would prefer that if possible.
I initially implemented it a bit differently, which was to remove this try/except. In this case it would have just thrown an Exception stating No such validator string/string
. Does this work for you?
from girder_worker.
I agree that No such validator string/string
is the correct error in this case so we should do that (and add a test for it). We should also implement and test that two valid formats with no path produces No path from a/b to a/c
instead of NetworkXNoPath
.
from girder_worker.
No such validator string/string
is a good start. But as zach said it would be nice to know the id of the input/output which is causing this error. If there is no way of knowing the ID in the converter_path then, maybe raise something like No such validator string/string
there and catch it somewhere else where the ID can be obtained and raise another exception there and give the ID.
from girder_worker.
My suggestion would be to wrap this logic in a try/except block and then raise something containing the types & formats as well as the ID. Within this block we should change it to two different try/excepts, one for the source tuple and one for the dest tuple, and if we raise an exception from that it should include the information from the offending tuple. Does that make sense?
from girder_worker.
+1 for what zach suggests
from girder_worker.
Also, can we use 'string' instead of 'text' for non-json format of string?
All other simple types seem to be like that except this.
from girder_worker.
Related Issues (20)
- RFC: Consider cache configuration in new girder worker tasks HOT 2
- Girder worker integration test plugin is not compatible with girder 3.
- Create "How to write an integration test" documentation for girder worker
- spaces in girder folder name are incorrectly converted to container args. HOT 5
- Check if Celery Pinning is still necessary HOT 24
- Docker in docker permission issue HOT 1
- Girder Client 2.4.0 breaking integration test HOT 7
- girder_plugin settings for worker.api_url, worker.broker, worker.backend are not being picked up correctly HOT 3
- Using kwargs in chained tasks fails to create Job object
- Revoke integration tests are hanging HOT 1
- girder_result_hooks cleanup methods are not called after task is done
- File paths from docker transforms should be wrapped in quotes HOT 1
- Document job event binding and output reference kwargs. HOT 7
- Running NVidia dockers
- docker_run can't process non-string arguments HOT 3
- Exceptions are silently ignored during plugin load
- Girder plugin: use setting default HOT 1
- Pin celery version in requirements.in HOT 1
- How can I pass env variables from within DSA to a image that is being added through slicer web task
- Is the "DIRECT_PATH" checkbox actually used ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from girder_worker.