GithubHelp home page GithubHelp logo

Comments (5)

zachmullen avatar zachmullen commented on June 19, 2024

This line in __exit__ takes care of ensuring logs are flushed once the task is complete.

from girder_worker.

manthey avatar manthey commented on June 19, 2024

Right, but the status is changed BEFORE the logs are flushed. Specifically, if you are listening for girder events where the log is updated, you can get a job whose status is completed but logs aren't flushed. This was surprising, as in a test I expected an error message to be in the logs when the error status was set (but it wasn't there yet).

from girder_worker.

manthey avatar manthey commented on June 19, 2024

I would recommend adding self._flush() in updateStatus before the status request is made.

from girder_worker.

zachmullen avatar zachmullen commented on June 19, 2024

I'm fine with that change.

from girder_worker.

manthey avatar manthey commented on June 19, 2024

Added in PR #65.

from girder_worker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.