Docker from within docker about girder_worker

[jeffbaumes]

I agree that any magic should be made part of girder_worker, so relying on dind does not seem like a good solution. Requiring paths to be the same on the host and in the container does not seem ideal, but running docker from within docker seems to be a not ideal situation regardless. Would @manthey's proposed change make anything more difficult or not backwards compatible for the normal (non-docker-in-docker) use case? If not we should probably go for it to be able to support girder_worker in docker.

[manthey]

See the comments on girder/slicer_cli_web#28. Getting rid of the entrypoint.sh script would also allow not mounting a script directory, and then Approach 1 above will work with the appropriate mount of tmp_root.

[zachmullen]

#93 addresses removal of the entrypoint script.

[manthey]

Resolved by PR #93. If you use mount the girder_worker tmp_root as a volume on the host with the same name as the girder_worker docker, docker jobs are run properly. I'll note that jobs that append custom docker run parameters might have issues, but I have no samples of those.

Thanks @zachmullen.