Sometimes HTML Diff is empty (wrong) about git-commit-notifier

[akzhan]

After deep research problem found in tamtam gem.

Will be replaced with premailer gem when good version will be released.

[akzhan]

already in master.

[ajardan]

It lloks like the issue still persists. We upgraded to 0.9.0 and still receiving sometimes empty diffs, however gitweb shows the content of updated files.

[akzhan]

Yes, trouble still persists. We need to do more debugging (I have tried do operations by hands but not yet found where it is).

[ajardan]

Are there any estimations, or maybe progress on this issue ?

[akzhan]

@ajardan, I haven't any estimations on it. Hand made steps to reproduce bug (using git commit notifier code from ruby console and commits that fail with empty html diff) produce correct html output. I do not take into account some unknown factors. May be you or somebody else?

[ajardan]

@akzhan We enabled debug on our SCM server, so hopefully we will catch something, as we see this problem almost every day. Will get back with more details, if possible.

[ajardan]

Actualy, the diff IS in the e-mail, if you look into the source of the message, it's in there, but not displayed in the html content.

--41d6b8c3fd2e62ff37c4e9a92367350fb97b15a7
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline

commit 5b823116ed401b611a8b1d8fbd38eb6a1dade7c0
Author: author
Date: Mon May 23 12:01:34 2011 +0100

commit message

diff --git a/file b/file
new file mode 100644
index 0000000..90934cc
--- /dev/null
+++ b/file

and after the diff, the HTML part is displayed, without any diffs, just the modified files, so the mail client only shows the html part.

[akzhan]

I should note that current version of git-commit-notifier works properly and have no empty diffs on our installation.

Anybody, have troubles with empty diffs in current 0.10.5 release?

[ajardan]

I will update the gem on our system soon and report back our findings. Thanks a lot !

[ajardan]

Seems to be working fine. Thanks !