previously.txt is always created in mode 644 about git-commit-notifier

[akzhan]

Will be done using file_mode parameter.

https://github.com/akzhan/git-commit-notifier/commit/0d4417972c0aa1bf64b6301d4ba792f2ab8de094

pull request sent.

[ened]

Thanks

[akzhan]

Take a note that file mode is Unix-specific functionality.

I suppose that default behaviour (operating system and umask dependent) is optimal one.

So we need to allow users override default settings in rare cases like issue #56.

[bitboxer]

I don't like this approach using a parameter. We should think about:

• why do we need this file anyway? is there a more elegant solution?
• would be 664 a better default?
• if not, can we get the file mode form another file in the repo and copy it?

[ened]

My users have a new umask set to 002 - I'm not completely in favor of that solution but it might work. I let you know if its any useful to us.

[akzhan]

This file(s) stores previously handled commits. This logic in codebase very old. I can't answer yet is it required.

People uses default settings and all work great in usual cases. So 0664 is not good default.

Yes, we can get file mode from old version of file and set it on new version of file (current logic is creation of file and replacing of the old one in one atomic operation).

[bitboxer]

No I don't mean to copy the file mode from the old version of the same file, I meant to copy the file mode from another file that is laying there in the repo since all git users must have the rights for those other files, too.

[ened]

Yes: "Yes, we can get file mode from old version of file and set it on new version of file (current logic is creation of file and replacing of the old one in one atomic operation)."

That would solve my problem completely!

I just checked, the notifier is resetting the mode to 644, ignoring the umask.

[akzhan]

@bitboxer, @ened, - I'll update code to copy mode from old file to the new one?

It is most correct way i suppose.

[bitboxer]

Copy the mode from which file? from the old file the system is recreating? Why not copy the file mode of another file in that repo? That way the first time the file is created the file mode will be correct.

[akzhan]

Yes I write about recreating only.

First run.. hm... which another file from?

[bitboxer]

I don't know which file would be the best. What about the config-file? Or go into the objects dir and get the first file there and copy it's file mode.

[krunkosaurus]

Again, any updates on this guys? :)