Email error with 0.9.0 about git-commit-notifier

[wvalters]

we are using the mailinglist config variable in the yaml file, not the Git hooks mail address.

[akzhan]

Very interesting... Are you correctly set git repo config?

[ajardan]

We have the same issue after upgrading to 0.9.0 from 0.8.1, so we switched to
delivery_method: smtp

Can I help anyhow with this ?

The mailinglist parameter in [hooks] is set correctly

[wvalters]

no tests fail, its wierd. i created some more tests and they all pass. We have the following kickoff script in /usr/local/bin/git-commit-notifier (leftover from 0.8.1 i presume it was before I got here). wonder if this is causing the issue

#!/usr/local/bin/ruby 
#
# This file was generated by RubyGems.
#
# The application 'git-commit-notifier' is installed as part of a gem, and
# this file is here to facilitate running it. 
#

require 'rubygems'

version = ">= 0"

if ARGV.first =~ /^_(.*)_$/ and Gem::Version.correct? $1 then
  version = $1
  ARGV.shift
end

gem 'git-commit-notifier', version
load Gem.bin_path('git-commit-notifier', 'git-commit-notifier', version)

[akzhan]

Please try to use version from trunk. is it weird or fine?

[wvalters]

Error:
remote: Sending mail...
remote: /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/lib/git_commit_notifier/emailer.rb:38:in mail_html_message': uninitialized constant GitCommitNotifier::Emailer::Emailer (NameError) remote: from /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/lib/git_commit_notifier/emailer.rb:120:insend'
remote: from /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/lib/git_commit_notifier/commit_hook.rb:117:in run' remote: from /usr/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:ineach_with_index'
remote: from /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/lib/git_commit_notifier/commit_hook.rb:101:in each' remote: from /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/lib/git_commit_notifier/commit_hook.rb:101:ineach_with_index'
remote: from /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/lib/git_commit_notifier/commit_hook.rb:101:in run' remote: from /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/lib/git_commit_notifier/executor.rb:14:inrun!'
remote: from /usr/local/lib/ruby/gems/1.8/gems/git-commit-notifier-0.9.0/bin/git-commit-notifier:15
remote: from /usr/local/bin/git-commit-notifier:19:in `load'
remote: from /usr/local/bin/git-commit-notifier:19

[bitboxer]

Akzhan, is this fixed? Should I release a .1 version?

[wvalters]

in testing im getting an error.

Counting objects: 5, done.
Writing objects: 100% (3/3), 248 bytes, done.
Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
remote: Sending mail...
remote:
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/emailer.rb:38:in
mail_html_message': uninitialized constant GitCommitNotifier::Emailer::Emailer (NameError) remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/emailer.rb:120:in send'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:117:in
block in run' remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in each'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in
each_with_index' remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in run'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/executor.rb:14:in
run!' remote: from /Users/wally/Source/github/git-commit-notifier/local-run.rb:16:in

'
To /Users/wally/Source/test2/../test
20170f8..5162a78 fred -> fred

Just got home and starting to look into it more...

On Mon, Apr 4, 2011 at 3:06 PM, bitboxer <
[email protected]>wrote:

Akzhan, is this fixed? Should I release a .1 version?

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_955765

[wvalters]

changing emailer.rb to use
html = GitCommitNotifier::Emailer.template.result(binding)

removed that error, but we are back to where it started...

remote: Sending mail...
remote: sendmail: fatal: Recipient addresses must be specified on the
command line or via the -t option

For some reason the recipients are not making to sendmail

On Mon, Apr 4, 2011 at 4:52 PM, Wally Valters [email protected] wrote:

in testing im getting an error.

Counting objects: 5, done.
Writing objects: 100% (3/3), 248 bytes, done.
Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
remote: Sending mail...
remote:
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/emailer.rb:38:in
mail_html_message': uninitialized constant GitCommitNotifier::Emailer::Emailer (NameError) remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/emailer.rb:120:in send'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:117:in
block in run' remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in each'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in
each_with_index' remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in run'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/executor.rb:14:in
run!' remote: from /Users/wally/Source/github/git-commit-notifier/local-run.rb:16:in

'
To /Users/wally/Source/test2/../test
20170f8..5162a78 fred -> fred

Just got home and starting to look into it more...

On Mon, Apr 4, 2011 at 3:06 PM, bitboxer <
[email protected]>wrote:

Akzhan, is this fixed? Should I release a .1 version?

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_955765

[wvalters]

Im lost. The recipients make it in to emailer, and are put in the To:
header...

On Mon, Apr 4, 2011 at 5:06 PM, Wally Valters [email protected] wrote:

changing emailer.rb to use
html = GitCommitNotifier::Emailer.template.result(binding)

removed that error, but we are back to where it started...

remote: Sending mail...
remote: sendmail: fatal: Recipient addresses must be specified on the
command line or via the -t option

For some reason the recipients are not making to sendmail

On Mon, Apr 4, 2011 at 4:52 PM, Wally Valters [email protected] wrote:

in testing im getting an error.

Counting objects: 5, done.
Writing objects: 100% (3/3), 248 bytes, done.
Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
remote: Sending mail...
remote:
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/emailer.rb:38:in
mail_html_message': uninitialized constant GitCommitNotifier::Emailer::Emailer (NameError) remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/emailer.rb:120:in send'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:117:in
block in run' remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in each'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in
each_with_index' remote: from /Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/commit_hook.rb:101:in run'
remote: from
/Users/wally/Source/github/git-commit-notifier/lib/git_commit_notifier/executor.rb:14:in
run!' remote: from /Users/wally/Source/github/git-commit-notifier/local-run.rb:16:in

'
To /Users/wally/Source/test2/../test
20170f8..5162a78 fred -> fred

Just got home and starting to look into it more...

On Mon, Apr 4, 2011 at 3:06 PM, bitboxer <
[email protected]>wrote:

Akzhan, is this fixed? Should I release a .1 version?

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_955765

[wvalters]

if i use POSTFIX instead of sendmail it works just fine (Mac OSX 10.6)

[wvalters]

well sort of... :) error in /var/log/mail.log instead of on the command line

[bitboxer]

I reopend it now.

[akzhan]

I made additional changes to move away some weird errors.

[wvalters]

Ill pull down and test some more
On Apr 5, 2011 6:37 AM, "akzhan" <
[email protected]>
wrote:

I made additional changes to move away some weird errors.

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_958557

[wvalters]

Still getting errors:

Counting objects: 5, done.
Writing objects: 100% (3/3), 248 bytes, done.
Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
remote: Sending mail...
remote: sendmail: fatal: wvalters(502): No recipient addresses found in
message header
remote: postdrop: warning: stdin: unexpected EOF in data, record type 78
length 138
remote: postdrop: fatal: uid=502: malformed input
To /Users/wvalters/Source/test/../test_remote
04ec2a2..e6b9886 brnch -> brnch

If i remove the -t from the sendmail options and place the recipient on the
command line it works.
The mail is messed up though, it shows both text and html parts at the same
time, abd the html is not HTML, it shows as the html source

example:

To: xxxxxxxxxxx

Subject: [/brnch] Test

X-Mailer: git-commit-notifier

X-Git-Refname: refs/heads/brnch

X-Git-Oldrev: b1b138c49595c9c719fbd7547df690fbe4b591cb

X-Git-Newrev: bba60ee0dd009342813d603e7e6644e44adcda4d

Mime-Version: 1.0

Content-Type: multipart/alternative;
boundary=8a85991f4804927387e03b0fdb6f5eceea0b123b

--8a85991f4804927387e03b0fdb6f5eceea0b123b

Content-Type: text/plain; charset=utf-8

Content-Transfer-Encoding: 8bit

Content-Disposition: inline

commit bba60ee0dd009342813d603e7e6644e44adcda4d
Author: Wally Valters XXXXXX@XXXXXXXXXX
Date: Tue Apr 5 07:22:14 2011 -0500

Test

diff --git a/tmp.txt b/tmp.txt
index 408ab54..8419a00 100644
--- a/tmp.txt
+++ b/tmp.txt
@@ -1 +1 @@
-dggggggggggf
\ No newline at end of file
+dgggggggggddddddd
\ No newline at end of file

--8a85991f4804927387e03b0fdb6f5eceea0b123b

Content-Type: text/html; charset=utf-8

Content-Transfer-Encoding: 8bit

Content-Disposition: inline

Message: Test
Commit: bba60ee0dd009342813d603e7e6644e44adcda4d
Branch: brnch
Date: Tue Apr 5 07:22:14 2011 -0500
Author: Wally Valters <[email protected]>

Changed file tmp.txt

1		Â dggggggggggf
2	1	\ No newline at end of file
	2	Â dgggggggggddddddd
3	3	\ No newline at end of file

--8a85991f4804927387e03b0fdb6f5eceea0b123b--

On Tue, Apr 5, 2011 at 6:51 AM, Wally Valters [email protected] wrote:

Ill pull down and test some more
On Apr 5, 2011 6:37 AM, "akzhan" <
[email protected]>
wrote:

I made additional changes to move away some weird errors.

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_958557

[akzhan]

No, it is https://github.com/bitboxer/git-commit-notifier/commit/279a6bd98c395794975f8e14f619b711bae00db9 - i suppose. There are changed structure of content.

[bitboxer]

But I don't see a change in the structure of the content?

[wvalters]

defintiely something with the header creation / interpretation, as all the
headers show up as email text when you put the recipient on the command
line.

On Tue, Apr 5, 2011 at 7:58 AM, akzhan <
[email protected]>wrote:

No, it is
https://github.com/bitboxer/git-commit-notifier/commit/279a6bd98c395794975f8e14f619b711bae00db9- i suppose. There are changed structure of content.

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_958825

[akzhan]

I have returned old message formation. Now it must work with sendmail (i hope).

[akzhan]

bitboxer - look here: https://github.com/bitboxer/git-commit-notifier/commit/5803779cf36e4cd6fdf7336e2b4652868879fd3d

there must be no \n characters at some places.

[wvalters]

There are a ton of changes between tag 0.8.1 and now.

Could premailer be causing some of the issue? if I remove the html part of
the message i still get an error for no recipients, but the EOF error goes
away.

On Tue, Apr 5, 2011 at 8:04 AM, Wally Valters [email protected] wrote:

defintiely something with the header creation / interpretation, as all the
headers show up as email text when you put the recipient on the command
line.

On Tue, Apr 5, 2011 at 7:58 AM, akzhan <
[email protected]>wrote:

No, it is
https://github.com/bitboxer/git-commit-notifier/commit/279a6bd98c395794975f8e14f619b711bae00db9- i suppose. There are changed structure of content.

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_958825

[akzhan]

are you got latest code, by the way? we use pemailer 1.5.7 for some months before.

[akzhan]

wvalters, is message sent by sendmail?

[wvalters]

checking out
https://github.com/bitboxer/git-commit-notifier/commit/279a6bd98c395794975f8e14f619b711bae00db9
starts the problem

commits prior to that one send email without a problem

On Tue, Apr 5, 2011 at 8:19 AM, akzhan <
[email protected]>wrote:

wvalters, is message sent by sendmail?

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_958910

[bitboxer]

Maybee it's the to_tag in the wrong scope?

On Tue, Apr 5, 2011 at 15:43, wvalters
[email protected]
wrote:

checking out
https://github.com/bitboxer/git-commit-notifier/commit/279a6bd98c395794975f8e14f619b711bae00db9
starts the problem

commits prior to that one send email without a problem

On Tue, Apr 5, 2011 at 8:19 AM, akzhan <
[email protected]>wrote:

wvalters, is message sent by sendmail?

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_958910

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_959007

[wvalters]

Bitboxer hit it on the head. yank all the \n from the content email
sends

ill send a pull req

On Tue, Apr 5, 2011 at 8:43 AM, Wally Valters [email protected] wrote:

checking out
https://github.com/bitboxer/git-commit-notifier/commit/279a6bd98c395794975f8e14f619b711bae00db9
starts the problem

commits prior to that one send email without a problem

On Tue, Apr 5, 2011 at 8:19 AM, akzhan <
[email protected]>wrote:

wvalters, is message sent by sendmail?

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_958910

[akzhan]

it was already pushed to master.

I suppose that we need to rollout new bugfix release.

[bitboxer]

Can I do this now?

[bitboxer]

Okay I relased it.

[wvalters]

looks good, testing locally sends via sendmail

On Tue, Apr 5, 2011 at 9:03 AM, bitboxer <
[email protected]>wrote:

Okay I relased it.

Reply to this email directly or view it on GitHub:
https://github.com/bitboxer/git-commit-notifier/issues/76#comment_959087