notifier hanging / memleak/ cpuhog about git-commit-notifier

[aikar]

aikar/cosmos@7e7ee7c

is the commit I did so you can see the level of diffs it was going to generate.

[akzhan]

Upgrade to last git-commit-notifier. Now we switched from tamtam to premailer/nokogiri.
Also new option exists that limit lines per diff.

[aikar]

just upgraded to ruby 1.9.1

gem install git-commit-notifier
Building native extensions. This could take a while...
Successfully installed diff-lcs-1.1.2
Successfully installed nntp-1.0.0
Successfully installed css_parser-1.1.9
Successfully installed htmlentities-4.3.0
Successfully installed nokogiri-1.4.4
Successfully installed premailer-1.7.1
Successfully installed git-commit-notifier-0.9.1
7 gems installed
Installing ri documentation for diff-lcs-1.1.2...
Installing ri documentation for nntp-1.0.0...
Installing ri documentation for css_parser-1.1.9...
Installing ri documentation for htmlentities-4.3.0...
Installing ri documentation for nokogiri-1.4.4...
Installing ri documentation for premailer-1.7.1...
Installing ri documentation for git-commit-notifier-0.9.1...
Updating class cache with 1382 classes...
Installing RDoc documentation for diff-lcs-1.1.2...
Installing RDoc documentation for nntp-1.0.0...
Installing RDoc documentation for css_parser-1.1.9...
Installing RDoc documentation for htmlentities-4.3.0...
Installing RDoc documentation for nokogiri-1.4.4...
Installing RDoc documentation for premailer-1.7.1...
Installing RDoc documentation for git-commit-notifier-0.9.1...

>>> psf git-commit
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
git      31637  100 12.8 607492 522732 ?       Rl   20:15   3:12                      \_ /usr/bin/ruby1.9.1 /var/lib/gems/1.9.1/bin/git-commit-notifier /etc/git-commit-notifier.cfg

[akzhan]

@aikar, firstly, ruby 1.9.1 is not production ready interpreter (unstable branch). You should use ruby 1.9.2 or ruby 1.8.7.

Secondly, try to limit lines_per_diff for big commits.

Thanks for your report, by the way.

[akzhan]

is process sucessfully finished or it was killed? In second case please copy call stack here.

[aikar]

i killed it and didnt get the stacktrace sorry.

I was having problems with 1.8 so i installed 1.9.1 and it fixed them.
anyways removed it and installed back 1.8 using ruby-full this time on apt-get (1.9.2 isnt there)

but i think the notifier needs to be smart and automaticallly limit lines. this kind of resource usage isnt acceptable.

[akzhan]

In my fork sequential commit handling algorithm now is used. This must decrease memory usage significantly when no email grouping enabled , but this is not throughly verified yet.

[akzhan]

Has been released as 0.10.0

[akzhan]

Memory used too much yet.

Solution will be done by #132 so this issue stay closed.