GithubHelp home page GithubHelp logo

Comments (9)

github-actions avatar github-actions commented on May 5, 2024

This issue is stale because it has been open 60 days with no activity.

from docs.

JamesMGreene avatar JamesMGreene commented on May 5, 2024

For the short term, we've also clarified this in the contributing/development documentation: 054f9ab

from docs.

FarazzShaikh avatar FarazzShaikh commented on May 5, 2024

@zeke Why not use the postinstall script in the package.json to run the build script. It only runs once after npm install.

cc: @JamesMGreene @janiceilene

from docs.

zeke avatar zeke commented on May 5, 2024

Good idea @FarazzShaikh! That might work. Would you care to give it a try and open a PR if it does?

from docs.

FarazzShaikh avatar FarazzShaikh commented on May 5, 2024

Will do later today! Could you assign this issue to me so it doesn’t slip my mind? Thank you!

from docs.

FarazzShaikh avatar FarazzShaikh commented on May 5, 2024

This does indeed work. Adding the script "postinstall": "npm run build" to package.json does build once after installations. However, one test (tests/routing/developer-site-redirects.js) fails when running npm run test but i don't think it's related to this.

Also, you might have to change your Actions workflows as npm ci also calls postinstall thus making the npm run build commands redundant.

@zeke if you're fine with this, I can make the changes to the workflows and the package.json then PR it in.

from docs.

JamesMGreene avatar JamesMGreene commented on May 5, 2024

@FarazzShaikh We're definitely open to that! FWIW, your PR will receive a message saying we don't accept contributions to workflow files but we're willing to make exceptions for small change sets like what you mentoned. 👍🏻

One suggestion, though, would be to use the prepare script instead of postinstall as that more closely aligns with our needs (building/transpiling code) semantically.

from docs.

FarazzShaikh avatar FarazzShaikh commented on May 5, 2024

Sounds good, I’ll make the required changes with prepare And PR it in

from docs.

JamesMGreene avatar JamesMGreene commented on May 5, 2024

We've decided not to implement this behavior for the time being.

More details: #7713 (comment)

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.