Comments (9)
This issue is stale because it has been open 60 days with no activity.
from docs.
For the short term, we've also clarified this in the contributing/development documentation: 054f9ab
from docs.
@zeke Why not use the postinstall
script in the package.json
to run the build script. It only runs once after npm install
.
cc: @JamesMGreene @janiceilene
from docs.
Good idea @FarazzShaikh! That might work. Would you care to give it a try and open a PR if it does?
from docs.
Will do later today! Could you assign this issue to me so it doesn’t slip my mind? Thank you!
from docs.
This does indeed work. Adding the script "postinstall": "npm run build"
to package.json
does build once after installations. However, one test (tests/routing/developer-site-redirects.js
) fails when running npm run test
but i don't think it's related to this.
Also, you might have to change your Actions workflows as npm ci
also calls postinstall
thus making the npm run build
commands redundant.
@zeke if you're fine with this, I can make the changes to the workflows and the package.json
then PR it in.
from docs.
@FarazzShaikh We're definitely open to that! FWIW, your PR will receive a message saying we don't accept contributions to workflow files but we're willing to make exceptions for small change sets like what you mentoned. 👍🏻
One suggestion, though, would be to use the prepare
script instead of postinstall
as that more closely aligns with our needs (building/transpiling code) semantically.
from docs.
Sounds good, I’ll make the required changes with prepare
And PR it in
from docs.
We've decided not to implement this behavior for the time being.
More details: #7713 (comment)
from docs.
Related Issues (20)
- harmonize permissions required for circleci migrator HOT 1
- Outdated documentation about $$ around math expression HOT 13
- Missing information in "Generate Installation Access Token" HOT 3
- "Reporting an issue or pull request", the documented feature does not exist on GitHub HOT 9
- .github/ISSUE_TEMPLATE/config.yml. HOT 2
- The current info on default community health files are not detailed enough to precedence of some of the community files HOT 3
- ডকুমেন্টেশন HOT 2
- docs.github.com HOT 1
- Clarification needed for pushing changes to a feature branch with git push HOT 3
- Formatting Error on Chinese 'Searching for Repositories' Page HOT 4
- Confusing verification step in "Installing Git Large File Storage" HOT 9
- OIDC examples don't pin external actions (& don't declare them) HOT 5
- `Repository limits` - `Commit listings limits` says `Github.com` HOT 2
- جووكر HOT 2
- Jekyll GFM processor claims it "will always match the results you see on GitHub" HOT 2
- Explicitly state that at least one job is required for a workflow HOT 3
- Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the [contributing guidelines](https://docs.github.com/en/contributing). HOT 1
- Mismatching types descriptions HOT 4
- Online Casino Philippines HOT 1
- [maintainer edit for spammy content] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docs.