Comments (4)
Do you think the second issue is related to this?
ReadStream(process.StandardOutput, output, cts.Token); ReadStream(process.StandardError, output, cts.Token);
These run in parallel, correct?
@luke-engle yep, that means that we're reading the StdErr and StdOut streams in parallel. Maybe we need to put a lock around the bits where we write the output to the console? (or rather, use a thread safe lock like a semaphore 😄)
from gh-valet.
Some updates here, @ethanis
I believe these are two separate problems.
The first, I can't seem to reproduce locally - only in a codespace. Interestingly, when you resize the browser window (changing the terminal size), the leftover progress bar disappears. In a codespace this happens very consistently, but I've tried many times and can't seem to reproduce the behavior in my local vscode terminal.
The second one I can produce locally if I remove the credentials store in ~/.docker/config.json
, and run gh valet update
. The output being mangled comes from the docker login command. When I run the docker login command directly: echo "$GH_PAT" | docker login ghcr.io --username luke-engle --password-stdin
, there is consistently no output mangling.
This seems to be an issue that's coming from the gh cli and/or gh-valet. I'm also wondering if it's a similar problem to the issue where the docker update command lists every image download in a newline instead of replacing previous downloads like we see when the docker command is run by itself in a terminal
from gh-valet.
Do you think the second issue is related to this?
ReadStream(process.StandardOutput, output, cts.Token);
ReadStream(process.StandardError, output, cts.Token);
These run in parallel, correct?
from gh-valet.
That's exactly what I was working on 😁
from gh-valet.
Related Issues (20)
- Point to new repo
- [Support]: valet unable to detect docker daemon HOT 4
- Add `--password-stdin` option to `gh valet update`
- [Support]: HOT 1
- Join or use gh-valet HOT 1
- Check if `valet-cli` container is current HOT 1
- Support linux-386 HOT 2
- [Support]: Azure DevOps audit trying to pull from nonexistent, non-default branch HOT 10
- [Support]: undefined method `[]' for nil:NilClass HOT 4
- [Support]: Support required HOT 2
- [Support]: SSL error when using valet for azure devops to Github Enterprise trial org pipeline migration HOT 2
- Expose new `migrate` command option `--workflow-file-prefix` HOT 1
- Progress bar persists on the console after command finishes HOT 1
- Create forecast subcommand for GitHub
- Display troubleshooting context if `update` command fails HOT 4
- [Support]: Cannot run valet commands HOT 6
- YAML files in multiple branches HOT 1
- Support darwin-arm64 HOT 7
- [Support]: Caching not working HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gh-valet.