Control+Shift+(key) doesn't work about hotkey

[keithamus]

Oh yeaaaah! Thanks for tracking that down @smridge. It's been a while since we visited this code so I had forgotten that's the behaviour.

I'll close this - given that @smridge has the solution. If it doesnt work for you @fatkhanfauzi please let me know and I'll re-open this ticket!

[smridge]

@fatkhanfauzi I initially had this issue as well and realized I needed to remove Shift+ and replace with an uppercase letter as explained in https://github.com/github/hotkey/blob/main/src/hotkey.ts

Control+Shift+s corrected to Control+S solved.

[keithamus]

Hey @fatkhanfauzi thanks for the issue

What element are you adding the attribute to? Can you show us some of the code you have? Does install get called? Do other shortcuts work but those don’t? Do shortcuts work on other elements but not this one?

[fatkhanfauzi]

hi @keithamus

yeah, install gets called and it works on Command+Shift+p (mac).
just the combination of Control+Shift+(key) that doesn't work.

However, it's weird when I added those keys to the unit tests, it doesn't raise any error.
Thanks

[keithamus]

You may find the browser is overriding the script behaviour.

[fatkhanfauzi]

not sure, as it doesn't work not only in chrome but also in firefox