Feature request: Image Upload about gitjournal

[vHanda]

It seems that this is one of the most voted issues, so I would like to start tackling it next week. However, I'm not sure exactly how to go about it. The main thing blocking me is the lack of a rich text editor in GitJournal.

So far my plan is the following -

• Add an image icon in the bottom app bar. The idea is to function similar to how Google Keep functions, it will open up a dialog which would allow to either choose from your gallery or take a photo with the camera.
• This photo would then be saved in either the save folder as the note or in a specific folder. This will be configurable. The filename which the note is saved with should ideally also be configurable.
• In the markdown editor, I'll add a button which allows you to add an image - This will show a dialog with 3 options - "An existing photo in the repo", "A photo from the gallery" or "Take a new photo". The relevant markdown will then be added to the editor.
• The FS view proposed in #91, should also be implemented and it should show the images present in the repo, and allow you to move/rename them.

These are quite a number of changes that would be required. Please let me know if I'm forgetting something else that would be required for this, or if anyone has any other ideas.

[igsol]

Absence of image support on the MarkDown pages is a real showstopper for me to use the application fully.

[vHanda]

I have not added this - "Add an image icon in the bottom app bar. The idea is to function similar to how Google Keep functions, it will open up a dialog which would allow to either choose from your gallery or take a photo with the camera.".

It made the bottom app bar look way too crowded. If someone wants that option please open a new bug, and I'll implement it + allow the bottom app icons to be configured.

[AronMav]

Hi. I'd like to see in next relises new format image-link how in Obsidian.md
![[media/Pasted image 6.png]]

[vHanda]

Hi. I'd like to see in next relises new format image-link how in Obsidian.md
![[media/Pasted image 6.png]]

Hey Aron. Could you please point me to the documentation on what this does differently than the standard markdown image format?

[AronMav]

Hi. I'd like to see in next relises new format image-link how in Obsidian.md
![[media/Pasted image 6.png]]

Hey Aron. Could you please point me to the documentation on what this does differently than the standard markdown image format?

Standart image format: https://www.markdownguide.org/basic-syntax/#images

Obsidian.md format (screen documentation): http://prntscr.com/u2onb6
![[media/Pasted image 6.png]]

[ddelange]

Would people 👍 to see a github/gitlab specific feature to upload media to their server instead of checking the files in, or 👎 is it out of scope?

Example media links generated using file upload dialog or drag & drop in the GitHub issue editor view

Pros:

• Much smaller repository size
• More scalable / performant

Cons:

• Increased complexity (https caching, ...?)
• Vendor lock-in
• ...?

[vHanda]

Would people 👍 to see a github/gitlab specific feature to upload media to their server instead of checking the files in, or 👎 is it out of scope?

Example media links generated using file upload dialog or drag & drop in the GitHub issue editor view

Pros:

• Much smaller repository size
• More scalable / performant

Cons:

• Increased complexity (https caching, ...?)
• Vendor lock-in
• ...?

It would probably be best to file a new issue about this. Also, maybe mention which API one could use to implement this.

Another option could be to use Git LFS, I think there is another issue tracking it.