Handling gsSPLine3D from Mario Kart 64 about n64

[glankk]

This is a bug in gfxdis.f3dex and gbi.h with -DF3DEX_GBI. A similar issue for SP1Triangle (#15) has been fixed, but is still present for SPLine3D.

[MegaMech]

Thank you so much! Just saved me a tonne of work.

[MegaMech]

I don't think this issue is resolved.
Original rom:
B5 00 00 00 06 00 0A 08
Compile:
B5 00 00 00 00 0A 08 00
Gfxdis:
gsSPLine3D(0, 5, 0),

Matching implementation:
mk_Spline3D(6, 0, 10, 8)

mk_gbi.h (hack for matching):

#define __mk_gsSPLine3D_w1f(v0, v1, v2, v3)		            	\
     (_SHIFTR((v3), 0,8)|_SHIFTL((v2), 8, 8)|	                  	\
     _SHIFTL((v1), 16, 8)|_SHIFTL((v0), 24, 8))

#define mk_Line3D(v0, v1, v2, v3)				            	\
{{								                  	\
	_SHIFTL(G_LINE3D, 24, 8)|0,                                 	\
	__mk_gsSPLine3D_w1f(v0, v1, v2, v3)			           		\
}}

It's suspected that mk64 used an older version of gbi.h. It's possible that there's nothing wrong with Line3D and mk is just different.

Also, is it possible to get gfxdis to continue reading the next DL after gsSPEndDisplayList()?

[glankk]

That's weird, I've never seen any G_LINE3D variant that takes four vertices, so that might very well be an old or custom version of F3DEX. If this line command is documented somewhere, it might be appropriate to include it in gfxdis.f3dexb and gbi.h when -DF3DEX_GBI -DF3D_BETA is used.
gfxdis does not support continuing after SPEndDisplayList or SPBranchList at the moment.