GithubHelp home page GithubHelp logo

Images missing about pocket2rm HOT 6 OPEN

andypillip avatar andypillip commented on July 22, 2024 1
Images missing

from pocket2rm.

Comments (6)

GliderGeek avatar GliderGeek commented on July 22, 2024

Hey, thanks for the kind words.
I actually think that there are no images extracted at all and only the links are kept.

from pocket2rm.

fedecupe avatar fedecupe commented on July 22, 2024

Hey, thanks for the kind words.
I actually think that there are no images extracted at all and only the links are kept.

Is this by design or is waiting implementation?

from pocket2rm.

GliderGeek avatar GliderGeek commented on July 22, 2024

This is not necessarily by design, but haven't really missed it myself so never took the effort.
Can imagine that very large images could pose a problem since the storage on the reMarkable is not that large?

from pocket2rm.

fedecupe avatar fedecupe commented on July 22, 2024

RM2 has > 6GB, also with only 10 articles...

from pocket2rm.

GliderGeek avatar GliderGeek commented on July 22, 2024

yeah, maybe not really a problem. i won't mind adding this

from pocket2rm.

andypillip avatar andypillip commented on July 22, 2024

I read some source code, and if I'm not mistaken, Readability will return XHTML with absolute URLs in the src attributes?

newSrc := toAbsoluteURI(src, ps.documentURI)
dom.SetAttribute(media, "src", newSrc)

Hence, it would be up to the epub package to go download that image file and add it to the epub – but it seems that it doesn't. Should it?

Instead, it offers a method addImage which probably we'd need to call ourselves for all media…

What is your understanding?

from pocket2rm.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.