GithubHelp home page GithubHelp logo

Comments (3)

ocean90 avatar ocean90 commented on June 27, 2024

The PR just adds the text domain and the load_plugin_textdomain() call. That's fine.

But there are some other issues:

  • Placeholders aren't explained in a translators comment
  • The use of _n() is wrong in some cases, like _n('One translation rejected.', '%d translations rejected.', $ok, 'glotpress' ), $ok );
  • Strings like __( 'edit', 'glotpress' ) should get a context: _x( 'edit', 'glossary', 'glotpress' )
  • esc_attr( __( ) ) => esc_attr__( )
  • echo _x( ) => _ex( )

How do we want to handle these? Move them into new issues?

from glotpress.

toolstack avatar toolstack commented on June 27, 2024

I'd vote for handling them as separate issues, they're all valid but shouldn't be a show stopper for 1.0 (maybe with the exception of _n()) , just something we can work on from release to release.

from glotpress.

polevaultweb avatar polevaultweb commented on June 27, 2024

+1 for a new 'enhancement' issue for after 1.0

from glotpress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.