Comments (3)
The PR just adds the text domain and the load_plugin_textdomain()
call. That's fine.
But there are some other issues:
- Placeholders aren't explained in a translators comment
- The use of
_n()
is wrong in some cases, like_n('One translation rejected.', '%d translations rejected.', $ok, 'glotpress' ), $ok );
- Strings like
__( 'edit', 'glotpress' )
should get a context:_x( 'edit', 'glossary', 'glotpress' )
esc_attr( __( ) )
=>esc_attr__( )
echo _x( )
=>_ex( )
How do we want to handle these? Move them into new issues?
from glotpress.
I'd vote for handling them as separate issues, they're all valid but shouldn't be a show stopper for 1.0 (maybe with the exception of _n()) , just something we can work on from release to release.
from glotpress.
+1 for a new 'enhancement' issue for after 1.0
from glotpress.
Related Issues (20)
- Warning/Fatal due to pentesting payloads
- Warning (PHP7) / Fatal (PHP8) triggered by user inputs in gp_array_get()
- GlotPress saves the wrong translation
- Allow importing translations from the new PHP format
- No warning is given when a fuzzy is approved that contains a missing placeholder like %1$s HOT 5
- AZB locale properties need to be updated HOT 8
- False positive match in Glossary term '&' HOT 4
- Version discussion and translation statistics in GlotPress HOT 2
- Improve discussion mails - Not send 1 per discussion string HOT 6
- Exporting as only "es" not "es_ES" HOT 1
- URLs without ending slash aren't fully recognized
- Breadcrumbs: All the items have links including the last one (current), only some have ending actions HOT 3
- Glossary: No matches for single words of part_of_speech with no suffix rules
- Glossary: Match by glossary terms already suffixed HOT 1
- We do not have a link to the project in the breadcrumbs when we create a new project
- Currently GlotPress gives unwanted error messages for missing uppercase at the start of the sentence.
- Cascading warnings from input on array functions HOT 3
- Add regex option to search
- Tables go out of the viewport in lower resolutions
- Glossary recognation issue with "-"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glotpress.