Comments (3)
Another idea is to replace the encoded ampersand in logout()
:
$logout_url = wp_logout_url( gp_url( '/' ) );
$logout_url = str_replace( '&', '&', $logout_url ); // wp_nonce_url() returns HTML escaped URLs
$this->redirect( $logout_url );
from glotpress.
That will solve the immediate issue, but won't protect logout from CSRF.
from glotpress.
I don't see any reason to keep the logout route so directly pointing to the WP logout link seems reasonable.
If there was some reason to keep it, would it make sense to use html_entity_decode() instead of just the str_replace() to make sure we catch everything?
from glotpress.
Related Issues (20)
- Add an action to recheck a translation for warnings HOT 2
- Update the translations filter counts and row status on ajax save or update status on the translation editor
- Discussion: add an en-US locale for "native plugins/theme's"?
- If you export the glossary, then chars as "'" are converted to old style char handling HOT 25
- if an original contains a glossary verb between %sreview%s then it is not indicated as glossary verb HOT 4
- Error when bulk saving waiting strings HOT 6
- Modify the header of the new wide GlotPress screen HOT 3
- Minification: Improve workflow for Pull Requests that contain changes to JavaScript files HOT 4
- Inline Translation: Improvements to the Popover
- Export error of untranslated strings starting or ending with new lines (\n) HOT 1
- Local: Manage conflicts on import from .org HOT 2
- Hide inline search list from GlotPress page
- Improve placeholders match and visibility HOT 1
- Glossary entry form fields in incorrect order
- A suggestion for the convenience of translation editors HOT 3
- Local: Disable submit button if placeholders are missing HOT 1
- If the last row of the list is translated and saved a javascript error is shown HOT 5
- Incorrect plural settings for ky HOT 1
- Enhancement to make the glossary more prominent
- Large Glossaries cause regular expression limit exhaustion. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glotpress.