Exception when merging Magnum and MassTransit into a new assembly about il-repack

[gluck]

Both your assemblies are already ILMerg'ed with Newtonsoft.Json (meaning they both define the types, as internal, you can see them using ildasm or reflector or ilspy...).
If you're lucky enough that the same version was used in both cases, try IL Repack with /union.

Let me know if it works.

[thejuan]

I'm using union already. :(
I hadn't noticed Magnum was using Newton as well.
Is there any way around it?

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 09 July 2012 14:31
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

Both your assemblies are already ILMerg'ed with Newtonsoft.Json (meaning they both define the types, as internal, you can see them using ildasm or reflector or ilspy...).
If you're lucky enough that the same version was used in both cases, try IL Repack with /union.

Let me know if it works.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[thejuan]

The should both be the same version

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 09 July 2012 14:31
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

Both your assemblies are already ILMerg'ed with Newtonsoft.Json (meaning they both define the types, as internal, you can see them using ildasm or reflector or ilspy...).
If you're lucky enough that the same version was used in both cases, try IL Repack with /union.

Let me know if it works.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[gluck]

I checked the code and /union is ignored if the types are internal, it prefers renaming the types (may not be the best choice).
If you feel adventurous, you may try hacking around ILRepack.cs:1370 to change that.

Otherwise I'll try the merge and see:

1. why the renaming doesn't work (likely some reference was missed during the rename process)
2. if we could check /union and/or dupTypes BEFORE renaming, even for internal types

Thx.

[thejuan]

Thanks, I changed that line to read

else if (type.FullName != "" && !type.IsPublic && !UnionMerge)

and it is working.

Adam

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 09 July 2012 15:15
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

I checked the code and /union is ignored if the types are internal, it prefers renaming the types (may not be the best choice).
If you feel adventurous, you may try hacking around ILRepack.cs:1370 to change that.

Otherwise I'll try the merge and see:

1. why the renaming doesn't work (likely some reference was missed during the rename process) 2. if we could check /union and/or dupTypes BEFORE renaming, even for internal types

Thx.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[thejuan]

The latest code base (or the way I am building) is causing Reference Resolution errors when I run it. It can't find my assemblies that are not being merged but are in the path specified for lib.
I'm just running the default debug build, should I be doing something different?
I was running 1.0.9 previously.

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 09 July 2012 15:15
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

I checked the code and /union is ignored if the types are internal, it prefers renaming the types (may not be the best choice).
If you feel adventurous, you may try hacking around ILRepack.cs:1370 to change that.

Otherwise I'll try the merge and see:

1. why the renaming doesn't work (likely some reference was missed during the rename process) 2. if we could check /union and/or dupTypes BEFORE renaming, even for internal types

Thx.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[thejuan]

It does work if I run it in the same directory as the lib dll's

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 09 July 2012 15:15
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

I checked the code and /union is ignored if the types are internal, it prefers renaming the types (may not be the best choice).
If you feel adventurous, you may try hacking around ILRepack.cs:1370 to change that.

Otherwise I'll try the merge and see:

1. why the renaming doesn't work (likely some reference was missed during the rename process) 2. if we could check /union and/or dupTypes BEFORE renaming, even for internal types

Thx.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[gluck]

Migration to latest Cecil may be causing this, I'll try to have a look as well.

[thejuan]

That change is also affecting anonymous types, it seems to be reusing the one anonymous type across all methods (so the properties don’t match)

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 10 July 2012 03:36
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

Migration to latest Cecil may be causing this, I'll try to have a look as well.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[thejuan]

Ok round 2.
I have removed the old change.
And changed line 93 of ReferenceFixator to
return ((TypeDefinition)type.DeclaringType).NestedTypes.First(x => x.FullName == type.FullName || x.FullName.EndsWith(">" + type.Name));

Not very elegant.
The nested type has a guid it's name but the type.FullName doesn't so it was not being found.

i.e.
ParentType/NestedTypeName vs ParentType/NestedTypeName

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 10 July 2012 03:36
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

Migration to latest Cecil may be causing this, I'll try to have a look as well.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[gluck]

You can try the latest sources, they should work properly, with either:

/allowdup:Newtonsoft.Json.* (to merge both versions of these types, can be used if they're known to be identical to reduce assembly size)

or no option at all (/union not required, as the conflicting types are internal, they'll be renamed automatically).

Cheers.

[thejuan]

Without the /allowdup (haven't tried it yet)
I get duplicate types in the assembly

Newtonsoft.Json.522512.<>f__Anonymouse Type0'2

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 11 July 2012 13:59
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

You can try the latest sources, they should work properly, with either:

/allowdup:Newtonsoft.Json.* (to merge both versions of these types, can be used if they're known to be identical to reduce assembly size)

or no option at all (/union not required, as the conflicting types are internal, they'll be renamed automatically).

Cheers.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[gluck]

That was the purpose indeed.
Without merging, Newtonsoft types from Magnum & MassTransit are seen as different types (different assemblies).
By renaming the types, we keep this coherence, and we have them duplicated in the merged assembly (which should still work properly).

If you're certain they're identical and want to avoid those duplicates, /allowdup is what you need.

[thejuan]

But without deduping I thought the renaming would prevent clashes?
I currently have clashes, I cant reflect the new the dll and I get errors about the duplicates when I open the dll in DotPeek (decompiler)

-----Original Message-----
From: Francois Valdy [mailto:[email protected]]
Sent: 13 July 2012 17:11
To: Adam
Subject: Re: [il-repack] Exception when merging Magnum and MassTransit into a new assembly (#10)

That was the purpose indeed.
Without merging, Newtonsoft types from Magnum & MassTransit are seen as different types (different assemblies).
By renaming the types, we keep this coherence, and we have them duplicated in the merged assembly (which should still work properly).

If you're certain they're identical and want to avoid those duplicates, /allowdup is what you need.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

[gluck]

And you thought right.
I tested with the latest binary drop of MassTransit and it seemed ok, but maybe I messed up somewhere, will try again.

[gluck]

The .Net 3.5 version of Magnum gave me a hard time, but it should be good now.
Beware to either use the binary drop of 1.13, or update Cecil fork as well (as some generics-related fixes were there).