CustomAttributes messed up about il-repack

[gluck]

When you say "merge with mscorlib" what do you mean/want to achieve?

[KenMacD]

I'm looking to inject a static class into mscorlib.dll and then inject calls to that class in the standard calls. I'm doing this to better monitor malware that is packed. It does things like unpack it's strings and code, and it also detects debuggers and most attempts to unpack.

What I want to do is take a small assembly with that static class and the mscorlib.dll from \Microsoft.NET\assembly\GAC_32\mscorlib\v4....\mscorlib.dll and put them together. I have some code to do this myself but it's not very robust so I was looking for anything that has already solved the problem.

[gluck]

This only occurs because you're merging mscorlib, which defines System.Int32 (etype == I4).
The base enum type then references the (newly created) merged type System.Int32 (etype == None).
When writing the assembly, having an enum overriding a custom value type isn't valid/supported.

I can't really tell if the behaviour should be changed for this use case, neither can I tell if things will work fine.

If you (still) want to pursue the use of ILRepack in this context, I suggest patching it so that you reuse the mscorlib AssemblyDefinition, and only import your extra stuff in it.
(ILRepack used to support this behavior, but it was 'hiding' too many issues, so I prefered merging all assemblies into a new empty one, instead of merging all others into the primary one)

PR welcome if you make that into an option (/reusePrimaryAssembly or something)