ILRepack removes MarshalInfo from method return types about il-repack

[gluck]

While that wouldn't be the first bug it has, it'd strange I didn't see this one before.
Are you using the latest version ? Can you put up a reproduction project ?

[DmitryKon]

Yes, I am using the latest version.

For reproduction just try to merge an assembly with the following class:

public class Test
{
    [DllImport("user32.dll")]
    [return: MarshalAs(UnmanagedType.Bool)]
    public static extern bool SetForegroundWindow(IntPtr hWnd);
}

You will see, that the [return: MarshalAs(UnmanagedType.Bool)] attribute will be stripped from the output assembly.

I fixed it in my local version like this (not sure if it is completely correct, but it works):

    // class ILRepack
    private void CloneTo(MethodDefinition meth, TypeDefinition type, bool typeJustCreated)
    {
        ...

        nm.ReturnType = Import(meth.ReturnType, nm);
        CopyCustomAttributes(meth.MethodReturnType.CustomAttributes, nm.MethodReturnType.CustomAttributes, nm);

        // BEGIN ADDED CODE
        if (meth.MethodReturnType.HasConstant)
            nm.MethodReturnType.Constant = meth.MethodReturnType.Constant;
        if (meth.MethodReturnType.HasMarshalInfo)
            nm.MethodReturnType.MarshalInfo = meth.MethodReturnType.MarshalInfo;
        nm.MethodReturnType.Attributes = meth.MethodReturnType.Attributes;
        // END ADDED CODE

        if (meth.HasBody)
            CloneTo(meth.Body, nm);

        ...
    }

[DmitryKon]

Thank you!