GithubHelp home page GithubHelp logo

Comments (10)

panarch avatar panarch commented on May 13, 2024 1

@KyGost Oh, thanks :) I'll close

from gluesql.

willy610 avatar willy610 commented on May 13, 2024

I have tested/verified corrections on a cloned repos.

How to proceed?

Create a new Branch?

Or await something from the community ?

from gluesql.

panarch avatar panarch commented on May 13, 2024

You can fork this repository and then GitHub will make cloned repository, url may become https://github.com/willy610/gluesql
Then, work on that cloned repo. After that you can make pull request to this main repo, then I can review your code change.

This process is based on GitHub, so if you are familiar with git but not GitHub, then you may spend some time to get used to it.

This page above looks good to see.

from gluesql.

willy610 avatar willy610 commented on May 13, 2024

It seems like the bug remains in the latest issue version = "0.1.16"

from gluesql.

panarch avatar panarch commented on May 13, 2024

Yes, because no one takes this issue yet.
If you'd like to do this then you can add PR and I'll review and merge.

from gluesql.

willy610 avatar willy610 commented on May 13, 2024

In glusql-main-3 literals with SingleQuotedString is accepted but nothing is stored.
Works fine with double quote.
Perhaps some unit tests is to be introducde in /tests/basic.rs

INSERT INTO Test (id, num, name) VALUES (1,2,'Job'):

INSERT INTO Test (id, num, name) VALUES ;

from gluesql.

willy610 avatar willy610 commented on May 13, 2024

Of cource should be with escaped strings

INSERT INTO Test (id, num, name) VALUES (3,4,'Job''s Macintosh');

from gluesql.

KyGost avatar KyGost commented on May 13, 2024

Looks like it sorts itself out for every command but INSERT. Working on this now.

from gluesql.

KyGost avatar KyGost commented on May 13, 2024

#145

from gluesql.

KyGost avatar KyGost commented on May 13, 2024

@panarch close?

from gluesql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.