Comments (4)
I was not suggesting to remove all counters. Only those that are relevant for dump time only.
from glusterfs.
Plus unless it's locked it's wrong anyway as it could be raced unless it's atomic_t types (which does a memory bus lock at time of read-update-store), and those you don't increment and decrement using ++ and/or -- operators.
from glusterfs.
Plus unless it's locked it's wrong anyway as it could be raced unless it's atomic_t types (which does a memory bus lock at time of read-update-store), and those you don't increment and decrement using ++ and/or -- operators.
But it done under lock. See
glusterfs/libglusterfs/src/inode.c
Line 2431 in 929d71b
from glusterfs.
I think we do need the LRU inode entries in table kept as a counter because we also have LRU limit, which this counter is checked against to determine if we need to invalidate some entries. So in my opinion rather sack the extra cycle or two on insert/remove rather than re-counting every time we need to know how many entries there are (if we have 2m table size that's 32MB of memory being traversed minimum, trashing page caches on the CPU as we go, and that's without traversing the individual chains).
from glusterfs.
Related Issues (20)
- transport.socket.source-addr is not available for IPv6 addr now
- Frequent disconectors in Glusterfs logs
- crash (unknown cause) with test mgmt-handshake-and-volume-sync-post-glusterd-restart.t HOT 1
- fuse_interrupt_finish_fop blocks all glfs_epoll threads and glfs_timer thread
- GlusterFS v11 geo-replication set_geo_rep_pem_keys.sh bug? HOT 1
- Flaky CI test - georep-basic-dr-rsync.t
- Transport endpoint disconnection errors during borg backup on GlusterFS Snapshot following upgrade to 11.1 HOT 8
- gnfs: Null pointer dereference segmentation fault during rename after failing to resolve destination GFID
- The GlusterFS client currently crashes (received signal 6) HOT 5
- shd does not start if gsyncd is missing HOT 4
- possible memory-leak in glusterfs-client "glusterfs 10.1"
- Remove-brick commit, open XXX file failed, subvol not update
- memory leak detected in glusterd
- GlusterFS Recovery Issue After Power Outage HOT 5
- Gluster expects bricks to be hosted on newly peer-probed machine...
- `cluster.op-version` mismatch on identical machines when installing from docs HOT 1
- Blocking ports 49147-49151 unexpectedly blocks connection to peers
- performance.nl-cache=on result in error messages __nlc_inode_clear_entries Assertion failed
- Memory Leaks Detected
- REPLICA issue in glusterFS with 3 nodes.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glusterfs.