Compile error: implicit declaration of function ‘copy_from_user’ about vendor-reset

[iggy]

My guess is some missing include in that old of a kernel. Maybe try including <linux/uaccess.h> directly in ioctl.c?

[kawogi]

Thanks, I tried that. dkms still looks like it's being blocked by some intermediate state.

$ sudo dkms install .
Error! DKMS tree already contains: vendor-reset-0.0.18
You cannot add the same module/version combo more than once.

make however seems to be sucessful:

$ make clean
make -C /lib/modules/4.19.0-13-amd64/build M=/home/kai/vendor-reset clean
make[1]: Entering directory '/usr/src/linux-headers-4.19.0-13-amd64'
make[1]: Leaving directory '/usr/src/linux-headers-4.19.0-13-amd64'

$ make
make -C /lib/modules/4.19.0-13-amd64/build M=/home/kai/vendor-reset modules
make[1]: Entering directory '/usr/src/linux-headers-4.19.0-13-amd64'
  CC [M]  /home/kai/vendor-reset/src/module.o
  CC [M]  /home/kai/vendor-reset/src/vendor-reset-dev.o
  CC [M]  /home/kai/vendor-reset/src/ioctl.o
  CC [M]  /home/kai/vendor-reset/src/ftrace.o
  CC [M]  /home/kai/vendor-reset/src/hook.o
  CC [M]  /home/kai/vendor-reset/src/amd/common.o
  CC [M]  /home/kai/vendor-reset/src/amd/compat.o
  CC [M]  /home/kai/vendor-reset/src/amd/firmware.o
  CC [M]  /home/kai/vendor-reset/src/amd/navi10.o
  CC [M]  /home/kai/vendor-reset/src/amd/polaris10.o
  CC [M]  /home/kai/vendor-reset/src/amd/vega10.o
  CC [M]  /home/kai/vendor-reset/src/amd/vega20.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/amdgpu_device.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/amdgpu_discovery.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/amdgpu_bios.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/amdgpu_atomfirmware.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/atom.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/common_baco.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/navi10_reg_init.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/navi12_reg_init.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/navi14_reg_init.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/polaris_baco.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/smu7_baco.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/vega10_reg_init.o
  CC [M]  /home/kai/vendor-reset/src/amd/amdgpu/vega20_reg_init.o
  LD [M]  /home/kai/vendor-reset/vendor-reset.o
  Building modules, stage 2.
  MODPOST 1 modules
  CC      /home/kai/vendor-reset/vendor-reset.mod.o
  LD [M]  /home/kai/vendor-reset/vendor-reset.ko
make[1]: Leaving directory '/usr/src/linux-headers-4.19.0-13-amd64'

make install however fails differently:

$ sudo make install
make -C /lib/modules/4.19.0-13-amd64/build M= INSTALL_MOD_PATH= modules_install
make[1]: Entering directory '/usr/src/linux-headers-4.19.0-13-amd64'
cp: cannot stat './modules.order': No such file or directory
make[3]: *** [/usr/src/linux-headers-4.19.0-13-common/Makefile:1304: _modinst_] Error 1
make[2]: *** [Makefile:146: sub-make] Error 2
make[1]: *** [Makefile:8: all] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.19.0-13-amd64'
make: *** [Makefile:11: install] Error 2

The mentioned file doesn't exist from my perspective as well.

This is all new to me so maybe I'm making some stupid mistake.

Would a kernel upgrade help? Any minimum version recommended?

[kawogi]

Ok I upgraded to 5.9 and I'm no longer able to boot the machine. Looks like nVidia kernel modules messed things up 👎
Old kernel doesn't boot any more as well. Also some nVidia error messages. Might take some time to figure that out.

[Ansa89]

To compile vendor-reset on old kernels, you might need this (ugly) patch:

--- a/src/ioctl.c
+++ b/src/ioctl.c
@@ -21,6 +21,7 @@ Place, Suite 330, Boston, MA 02111-1307 USA
 #include "vendor-reset-ioctl.h"
 
 #include <linux/miscdevice.h>
+#include <linux/uaccess.h>
 
 #define VENDOR_RESET_IOCTL_DEVNAME "vendor_reset"
 

[kawogi]

That's what @iggy suggested. I had a lot of follow up problems, so I'm currently rebuilding the machine using the latest Manjaro (minimal). Will report back.

[kawogi]

Cannot reproduce the problem with a more recent kernel and build environment.