Comments (3)
Maybe I wasn't clear enough. By "the Lego library doesn't account for that" I meant that the library part of the project (as opposed to the command line tool), specifically the GetRenewalInfo
method, ignores the header value. This diff fixes that. It is up to whoever implements the library to decide if and how to use the newly provided value. In my case, I can use it in my custom-made service to set the next time when to rerun the renewal check process.
If I'm understood now and we agree on the issue, can I begin with a PR?
from lego.
Hello,
The only constraint for a client is to follow suggestedWindow
(MUST).
The support Retry-After
is recommended (SHOULD) but not required.
Your patch gets the Retry-After
information but doesn't use it.
You can open a PR, you will have to add the missing elements.
Note: please use "
for string
, and explicit field name inside tests.
from lego.
ok, let's go for a PR.
from lego.
Related Issues (20)
- on armv7I-32 CPU: this CPU has no VFPv3 floating point hardware HOT 3
- renew doesn't take multiple domains HOT 1
- "The HTTP S3 Present should not utilize Object ACL permissions, as they are not recommended."
- acme: error presenting token: alicloud: zone com. not found in AliDNS for ... HOT 2
- oraclecloud is using only default realm OC1 for all requests HOT 7
- Missing and misleading hook environment variables HOT 4
- Add support for Route53 private zones HOT 2
- '--dns exec' show output in real time? HOT 3
- Add SLSA provenance to your releases
- renew-hook does not support quoted parameters HOT 1
- DNS request prefer IPv6 only HOT 1
- exoscale: fails when issuing certificate for "*.domain.example" and "domain.example" HOT 16
- Ability to update email using the CLI
- Support for provider: mittwald HOT 8
- azuredns: CLI authentication doesn't respect tenant setting
- DNS certificates with many names: Faster verification HOT 13
- Support hook arguments HOT 3
- Whether you can support manual custom validation of DNS records in golang dependent mode?
- Leftover deprecated update renewal info call
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lego.