Comments (33)
I can probably make a proof of concept for this sometime during the weekend or next week
from gitea.
hi. I use it for quick drafts this tool:
from gitea.
I can look at this, but this will be not so fast
from gitea.
no problem. I will do what I need
I'll take your code and I'm already working on the correct code.
from gitea.
@qdbdbp, what tool do you use to do those designs? 😅
from gitea.
Hello.
I send you a preview of the model of action.
This is a static implementation - proof of concept
from gitea.
I send the draft as seen to comment on the code.
For some time I will show demo work.
from gitea.
Please follow #3748
from gitea.
Is comment in commits implemented? If it isn't implemented I think this should be reopen
from gitea.
👍, I will do it
from gitea.
well, If we implement comments on commits
we should get this "for free" 🙂
from gitea.
I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.
from gitea.
Yes, comment on commits.
from gitea.
@bkcsoft any update?
from gitea.
Aren't we going to do this with git-appraise ? See #733
from gitea.
Move this v1.2 since #733 has moved.
from gitea.
I have tried to do something. Comments on PR
is not the same as comments on commits
. These are two similar PRs. For comments on PR
, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for comments on commits
, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).
from gitea.
@qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?
from gitea.
I send updated versions.
I'm waiting for comments on this.
from gitea.
@qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.
from gitea.
@qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?
from gitea.
@qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.
from gitea.
I don't mind to pay to have this feature... how much? who?
from gitea.
@bclermont we already have a wip pull request #2583.
from gitea.
@lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature
from gitea.
You could use https://www.bountysource.com/teams/go-gitea
from gitea.
@lunny thanks for posting that link. I added to the bounty.
from gitea.
Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the only feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!
from gitea.
I will give equivalent of 100$ in a crypto currency to whoever earn the bounty
from gitea.
Are there things to follow?
from gitea.
@xxxTonixxx right, Only pull request comment was implemented by #3748 . @lafriks @JonasFranzDEV
from gitea.
But we could open another issue to keep this one closed.
from gitea.
@xxxTonixxx Thank you!
from gitea.
Related Issues (20)
- comparison api unable to calculate the difference between the commit IDs HOT 1
- Can not create merge commit when checks succeed HOT 1
- Slow response on repo/search
- Automatically restart runner after a crash HOT 2
- Checkbox offset on settings -> application page
- UI border-radius inconsistent problems HOT 1
- Merged/Closed PR should not be approvable or request changes in diff page?
- Job will be frozen when stop the runner after job success
- setup gitea as oauth idP behind nginx sub-path fail HOT 6
- Consider relaxing access constraints on `/api/users/{username}/keys` HOT 3
- Project board column abel visual bug
- New pull request imagediff js error HOT 4
- Pull request search shows merged PRs in Open tab HOT 4
- Reproducible builds and strict dependency verification HOT 13
- Display error in web page when merge failed
- I hope to add multiple directories under the organization directory to group warehouses HOT 1
- About.Gitea Typos HOT 2
- GetInfoRefs() [E] signal: killed HOT 8
- Wrong `project_board_id` for newly created issue HOT 6
- Fix test for #30674
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitea.