GithubHelp home page GithubHelp logo

Comments (8)

wxiaoguang avatar wxiaoguang commented on May 22, 2024 1

Does this work for you?

[repository.pull-request]
WORK_IN_PROGRESS_PREFIXES = WIP:,[WIP],Draft:,[Draft]

image

from gitea.

silverwind avatar silverwind commented on May 22, 2024

Almost, but I would like to also get rid of the PR title modification too.

Maybe we can make it work by setting WORK_IN_PROGRESS_PREFIXES to the empty string, but I suspect the detection of the status may be based on the title prefix, e.g. no separate DB field.

from gitea.

wxiaoguang avatar wxiaoguang commented on May 22, 2024

Hmm .... I see your point. To me, I like adding a prefix to the PR. For example, when I browse the PR list, I can't easily figure out different PRs by the icons (which is draft, which is not), I mainly depends on the title & prefix.

If it would get rid of the PR title modification .... it seems to need a lot of work ...... IIRC the current approach heavily depends on the prefix.

from gitea.

silverwind avatar silverwind commented on May 22, 2024

For me, icon alone is enough indication. Yes it would require more work because a new DB field needs to be added and a new event type for draft status. So instead of

image

we would see " marked the pull request as draft" and " marked the pull request as ready for review".

from gitea.

silverwind avatar silverwind commented on May 22, 2024

Reason for the change is also that it might be possible that in the future, workflows may be ran when pull request title changes (like spellcheck), and the current "abuse" of the title would cause such workflows to unnecessarily run.

from gitea.

wxiaoguang avatar wxiaoguang commented on May 22, 2024

Reason for the change is also that it might be possible that in the future, workflows may be ran when pull request title changes (like spellcheck), and the current "abuse" of the title would cause such workflows to unnecessarily run.

It sounds more like a workflow's bug. IMO the "title modification" shouldn't trigger a workflow --- does it really make sense? 🤔

from gitea.

silverwind avatar silverwind commented on May 22, 2024

If you want to spellcheck a PR title, you have'd such a hypothetical event like on: title_change 😆.

from gitea.

silverwind avatar silverwind commented on May 22, 2024

It seems to be possible on GitHub at least: https://github.com/orgs/community/discussions/48695

from gitea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.