GithubHelp home page GithubHelp logo

Comments (7)

yp05327 avatar yp05327 commented on June 18, 2024

image
margin-right will become bigger

from gitea.

yp05327 avatar yp05327 commented on June 18, 2024

https://forum.freecodecamp.org/t/issues-with-bootstrap-5-2-modal/570924

this will be added after open a modal
image

from gitea.

wxiaoguang avatar wxiaoguang commented on June 18, 2024

No, not "upstream".

The tw-overflow-hidden was introduced by Remove fomantic dimmer module #30723 ,

from gitea.

yp05327 avatar yp05327 commented on June 18, 2024

but it seems that margin-right is from bootstrap 🤔

from gitea.

silverwind avatar silverwind commented on June 18, 2024

The tw-overflow-hidden on body could maybe replaced with pointer-events-none on the dimmer to inhibit scrolling the body while modal is open. But I'm pretty sure fomantic used the former too.

Edit: Ah no, that would prevent closing the modal with dimmer click.

from gitea.

silverwind avatar silverwind commented on June 18, 2024

Margin is coming from fomantic modal module:

https://github.com/fomantic/Fomantic-UI/blob/59d9b409879ad9413ea0a3efa4ab2e51017ad9b9/src/definitions/modules/modal.js#L611-L617

from gitea.

silverwind avatar silverwind commented on June 18, 2024

#30831 will fix it.

from gitea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.