Comments (17)
+1 without protected branches system, Gitea will be not ready for a corporate environment where is not acceptable to ask at each developers to use the "fork and pull request" flow.
from gitea.
+1 desperately in need for this.
from gitea.
@lunny no need for all that, just a simple branch X can't be pushed to
would suffice to start with 🙂
As for status check, that would be fairly simple to implement really (if one does as GitHub API does)
from gitea.
#339 is the first part merged for this issue, so let's move it to v1.2.
from gitea.
@exp10r3r We have #339 merged a simple protected branch system. Of course we need more features.
from gitea.
@ptman Unfortunately, no. More than 50% from NodeJS, 10% php and the rest html/css.
@lunny I know, and I have been following development since you guys forked and personally using it since last 15 days.
The issue arose from the fact that I had given the rest of my team write access to the repo and marked master branch as protected.
I only want them to be able to push to the feature branch, after which a PR is made and only the person with push rights to master can merge this PR.
Imagine my surprise when a dev was merging his own PRs.
Obviously it was an oversight on my end, I should have tested this first hand.
I'm glad though that force pushes are not allowed, that would have been a nightmare.
Anyways, a good branch protection scheme will go a long way in increasing gitea's value proposition.
from gitea.
@svarlamov yes, we need only 1 PR to show the status check on PR UI since all data have been ready.
from gitea.
Please don't prefix the issue with [Feature]
, that should be done via labels. This is an important feature for an lgtm.co integration, so a big 👍 for that.
from gitea.
I think this need a proposal to describe it.
from gitea.
@lunny Agreed. I've looked into this issue before, and it requires a rewrite of how GitHooks are currently Exposed.
Reference: gogs/gogs#776 (comment)
from gitea.
@DblK "proposal" proposed process is here https://github.com/go-gitea/proposals/pull/1
from gitea.
Before we can start protected branch, we have to finish the dependent features first:
- code review, this is based comment on code, but add a flag to disable merge button until the comment author close it.
- status check system, this is based webhook. and it's a specific webhook. We could define it like github.
- rebase the PR.
Implement every one feature will not result many commits, so we can do it step by step.
Welcome to improve it.
from gitea.
Only thing stopping us moving to gitea now.
We have a company 1k dev strong.
Please, I urge the community to focus on this.
from gitea.
@exp10r3r Do you have any golang devs that could help?
from gitea.
Even implementing this would go along a long way.
from gitea.
Now that we have protected branches and whitelisting, what would it take to add status checks similar to: https://help.github.com/articles/enabling-required-status-checks/
from gitea.
I think this issue has been resolved.
from gitea.
Related Issues (20)
- Performance issue on pulls list API endpoint with lots of PR's
- Disallow deeply nested CSS selectors HOT 1
- When saving an LFS PDF file on Minio, the PDF preview may fail when SERVE_DIRECT is set to true.
- Gitea 1.22 detected as virus by windows defender HOT 7
- 405 Method Not Allowed: [no body]. But actually it is the right method HOT 2
- Get a list of all commits from a repository will lost some file sometimes HOT 3
- Commit history overflow in issue page HOT 4
- pre-receive hook error after updating HOT 9
- Button color regression
- Propose to restart 1.22 release HOT 7
- Non-admin user doesn't show repo dummy description HOT 4
- How to migrate data between Gitea servers? HOT 4
- Field login_name is empty after create an user
- To clone the project locally, execute 'make build' and get the following error HOT 10
- Watch/Unwatch, Star/Unstar buttons style error. Wrong radiuses have been added. HOT 1
- downgrade database version from 280" to'189" is not supported and may result in loss of data integrity. HOT 7
- Update failed if the `website` field is carried, when requesting `/user/settings` interface. HOT 3
- import from gogs /github.
- Install page UI regression
- Admin config page UI regression HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitea.