GithubHelp home page GithubHelp logo

Fix linting error about gitea HOT 12 CLOSED

go-gitea avatar go-gitea commented on May 1, 2024
Fix linting error

from gitea.

Comments (12)

tboerger avatar tboerger commented on May 1, 2024 1

On the other side, we will drop the bindata from the repo soon, than it's not part of the repo anymore

from gitea.

DblK avatar DblK commented on May 1, 2024

Do you would like to have a huge PR or smaller PR by folder for example?
I saw on lint it misses several comments for each function.

Tell me what you want.

from gitea.

xinity avatar xinity commented on May 1, 2024

@DblK smaller PR are easier to review :)

so i'd vote for smaller ones

from gitea.

tboerger avatar tboerger commented on May 1, 2024

👍 for smaller prs, as @xinity said it's better to review

from gitea.

tboerger avatar tboerger commented on May 1, 2024

But continue with the models, I already started parts within the makefile pr

from gitea.

lunny avatar lunny commented on May 1, 2024

Only modules/bindata/bindata.go not be fixed. But that file is generated by go-bindata. Any idea? @tboerger

from gitea.

tboerger avatar tboerger commented on May 1, 2024

Switch to a proper bindata tool like fileb0x (but it doesn't support tags) or go.rice or somehow ignore it

from gitea.

lunny avatar lunny commented on May 1, 2024

But maybe we can ingore the golint check on Makefile at first. So that we an close this issue and ask all the PR to pass the golint.

from gitea.

tboerger avatar tboerger commented on May 1, 2024

Maybe you can filter out the bindata package from the list temporary? Like grep -v

from gitea.

strk avatar strk commented on May 1, 2024

@lunny if you find out how to ignore a single file, I'm all for going with it, especially as after a "make" invocation you'd have the bindata.go around and it might be annoying to get those false positives

from gitea.

tboerger avatar tboerger commented on May 1, 2024

On the short term we can simply ignore the entire code.gitea.io/gitea/modules/bindata package.

from gitea.

lunny avatar lunny commented on May 1, 2024

So this could be closed via #303

from gitea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.