Comments (12)
On the other side, we will drop the bindata from the repo soon, than it's not part of the repo anymore
from gitea.
Do you would like to have a huge PR or smaller PR by folder for example?
I saw on lint it misses several comments for each function.
Tell me what you want.
from gitea.
@DblK smaller PR are easier to review :)
so i'd vote for smaller ones
from gitea.
👍 for smaller prs, as @xinity said it's better to review
from gitea.
But continue with the models, I already started parts within the makefile pr
from gitea.
Only modules/bindata/bindata.go
not be fixed. But that file is generated by go-bindata. Any idea? @tboerger
from gitea.
Switch to a proper bindata tool like fileb0x (but it doesn't support tags) or go.rice or somehow ignore it
from gitea.
But maybe we can ingore the golint check on Makefile at first. So that we an close this issue and ask all the PR to pass the golint.
from gitea.
Maybe you can filter out the bindata package from the list temporary? Like grep -v
from gitea.
@lunny if you find out how to ignore a single file, I'm all for going with it, especially as after a "make" invocation you'd have the bindata.go around and it might be annoying to get those false positives
from gitea.
On the short term we can simply ignore the entire code.gitea.io/gitea/modules/bindata
package.
from gitea.
So this could be closed via #303
from gitea.
Related Issues (20)
- JS error: JavaScript promise rejection: TypeError: null is not an object (evaluating 'userSettings.serverConfig.environment.vault'). Open browser console to see more details. HOT 4
- Gitea action user avatar broken on edit
- Upgrade from 1.18.5 to 1.21.5 in Docker - can't login HOT 3
- Gitea ZIP Download of LFS Files downloads the pointer HOT 2
- User notification webhooks
- contributors graph respect "Co-authored-by" HOT 2
- Update branch by merge UI problem in mobile view
- Contributors page doesn't look good on mobile view HOT 4
- Gitea 1.21.4 adds 'user-content-' in markdown file HOT 11
- No configuration to modify KeepActivityPrivate setting HOT 2
- Workflows are not triggered for edited issues HOT 1
- 500 while creating users HOT 3
- Migration from own gitlab not working HOT 7
- Removing of spent time in Issue activity results in 404 if time tracking is disabled
- There is no ability to get "Ready Time" for pull request via Open API HOT 3
- 500 while edit a user with a not-allowed visibility
- .conf files not being rendered for preview because it thinks its binary HOT 1
- Cannot download source tarballs via API token authorization
- Hide repositories while keeping them public ? HOT 5
- Do not rebuild your dev container now HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitea.